Feeling Lucky
?
[#8119] - Remove empty div in control panel if there are no postinstall messages.
- Closed
- 24 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 8119
- Diff
- Harmageddon:cpanel_postinstall_div
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Testing instructions
- Log in to backend.
- Hide all postinstall messages.
- Inspect the source code for the admin control panel (administrator/index.php). There is an empty div that previously contained the postinstall messages.
- Apply the patch.
- Inspect the source code again. The empty div should be gone.
- Reset the postinstall messages to display them again in the control panel.
- Make sure the messages are still displayed correctly.
Attribution
This issue and the corresponding fix have been reported / proposed by user Cartho on joomla-bugs.de (Original Thread).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration |
| Easy | No | ⇒ | Yes |
Michaelmyk
- comment
- 24 Oct 2015
I have tested this item 
successfully on 821f03f
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.
designbengel
- comment
- 24 Oct 2015
I have tested this item successfully on 821f03f
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.
joomlamarco
- comment
- 24 Oct 2015
test successfull. works as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.
| Status | Pending | ⇒ | Ready to Commit |
SniperSister
- comment
- 24 Oct 2015
3 successful tests, setting to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 10:06:32 |
| Closed_By | ⇒ | Bakual |
Bakual
- comment
- 24 Oct 2015
Merged, thanks!
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
zero-24
- | Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
Looks fine from review and makes sense.
Can you maybe adjust the indent of the inner HTML block? Since you remove an if clause.