? Success

User tests: Successful: Unsuccessful:

avatar Harmageddon
Harmageddon
21 Oct 2015

Testing instructions

  1. Log in to backend.
  2. Hide all postinstall messages.
  3. Inspect the source code for the admin control panel (administrator/index.php). There is an empty div that previously contained the postinstall messages.
  4. Apply the patch.
  5. Inspect the source code again. The empty div should be gone.
  6. Reset the postinstall messages to display them again in the control panel.
  7. Make sure the messages are still displayed correctly.

Attribution

This issue and the corresponding fix have been reported / proposed by user Cartho on joomla-bugs.de (Original Thread).

avatar Harmageddon Harmageddon - open - 21 Oct 2015
avatar Harmageddon Harmageddon - change - 21 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2015
Labels Added: ?
avatar Harmageddon Harmageddon - change - 21 Oct 2015
Category Administration
avatar Harmageddon Harmageddon - change - 21 Oct 2015
Easy No Yes
avatar Bakual
Bakual - comment - 21 Oct 2015

Looks fine from review and makes sense.
Can you maybe adjust the indent of the inner HTML block? Since you remove an if clause.

avatar Harmageddon
Harmageddon - comment - 21 Oct 2015

@Bakual Ah, you're right, thanks! Fixed it.

avatar Michaelmyk Michaelmyk - test_item - 24 Oct 2015 - Tested successfully
avatar Michaelmyk
Michaelmyk - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 821f03f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.

avatar designbengel designbengel - test_item - 24 Oct 2015 - Tested successfully
avatar designbengel
designbengel - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 821f03f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.

avatar joomlamarco
joomlamarco - comment - 24 Oct 2015

test successfull. works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.

avatar SniperSister SniperSister - change - 24 Oct 2015
Status Pending Ready to Commit
avatar SniperSister
SniperSister - comment - 24 Oct 2015

3 successful tests, setting to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8119.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar Bakual Bakual - change - 24 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-24 10:06:32
Closed_By Bakual
avatar Bakual Bakual - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar Bakual Bakual - reference | 7e7d53c - 24 Oct 15
avatar Bakual Bakual - merge - 24 Oct 2015
avatar Bakual Bakual - close - 24 Oct 2015
avatar Bakual
Bakual - comment - 24 Oct 2015

Merged, thanks!

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar Bakual Bakual - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment