[#8065] - Wrong message after publishing nested sub-items
- Closed
- 17 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 8065
- Diff
- infograf768:fail_publishing
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR to replace #8038 where nested is not taken into account.
How to test:
Navigate to Category Manager
Create a main category
Create a sub-category that is related to the new main category
Unpublish the main category
Both main & sub-category will get unpublished
Click on the sub-category and try to publish and check the message
Do the same for sub_menus and sub_tags
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration UI/UX |
| Easy | No | ⇒ | Yes |
We should use an error message type when it's not successful. Nice spot tho JM :)
General question. Should we queue the actual error messages? So the user actually understands why things have failed. For example if they haven't touched the parent category for a while they might be confused that they can't publish the child cateogry
Obviously though this is a needed bug fix!
As we check that the reason for failing is clear, I am changing the string values.
Example:
COM_TAGS_N_ITEMS_FAILED_PUBLISHING="Failed publishing %d tag as at least one of their parents is unpublished."
COM_TAGS_N_ITEMS_FAILED_PUBLISHING_1="Failed publishing %d tag as at least one of its parents is unpublished."
I have tested this item 
successfully on 96595de
Works perfect for me. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8065.
I haven't got the complete context in front of me just now but 'failed to publish...' is better en-GB than 'failed publishing...'.
Folks, let's wait for that one. I found a possible problem in nested.php which may have to be solved first.
See #8082
If it can't be solved, we may have to add a new condition in this PR with new language strings, or simplify with no condition by not explaining in the string the reason of the failure.
This PR has received new commits.
CC: @YouriiM26
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8065.
Changed PR as it is unlikely that #8082 would be changed.
The new string is now of the type:
COM_CATEGORIES_N_ITEMS_FAILED_PUBLISHING="Failed publishing %d categories as at least one of their parents is unpublished or one of their children is checked out."
COM_CATEGORIES_N_ITEMS_FAILED_PUBLISHING_1="Failed publishing %d category as at least one of its parents is unpublished or one of its children is checked out."
Thank you for testing again.
I have tested this item successfully on 93157fa
Patch works.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8065.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8065.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-17 10:18:22 |
| Closed_By | ⇒ | rdeutz |
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
| Labels |
Removed:
?
|
||
Result would be of the type:
