Your text says insert article inside article. ??
On 11 Oct 2015 2:36 pm, "Dimitris Grammatiko" notifications@github.com
wrote:

What is this?

Another button bellow the editor that allows people to easily insert an
article to their article
Once the button get their position inside tinyMCE this will look a lot
better.
How to test

Apply this PR with patch tester
Go to discover and install the new plugin
Edit an article (fronted/backend) and make sure that the module is inserted
Preview

[image: screenshot 2015-10-11 16 35 09]

https://cloud.githubusercontent.com/assets/3889375/10417002/1ffbb48e-7036-11e5-8f46-f2b384587038.png

You can view, comment on, or merge this pull request online at:

#8064
Commit Summary

• init

File Changes

• A administrator/components/com_modules/views/modules/tmpl/modal.php https://github.com/joomla/joomla-cms/pull/8064/files#diff-0 (206)
• M administrator/components/com_modules/views/modules/view.html.php https://github.com/joomla/joomla-cms/pull/8064/files#diff-1 (5)
• A administrator/language/en-GB/en-GB.plg_editors-xtd_module.ini https://github.com/joomla/joomla-cms/pull/8064/files#diff-2 (8)
• A administrator/language/en-GB/en-GB.plg_editors-xtd_module.sys.ini https://github.com/joomla/joomla-cms/pull/8064/files#diff-3 (10)
• A components/com_modules/controller.php https://github.com/joomla/joomla-cms/pull/8064/files#diff-4 (41)
• A components/com_modules/modules.php https://github.com/joomla/joomla-cms/pull/8064/files#diff-5 (21)
• A plugins/editors-xtd/module/module.php https://github.com/joomla/joomla-cms/pull/8064/files#diff-6 (56)
• A plugins/editors-xtd/module/module.xml https://github.com/joomla/joomla-cms/pull/8064/files#diff-7 (19)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/8064.patch
• https://github.com/joomla/joomla-cms/pull/8064.diff

—
Reply to this email directly or view it on GitHub
#8064.

Thanks Brian,

It’s the fever effect I guess

If the tinymce update that puts the buttons into the toolbar is accepted
then this is a great addition. If its not then it just adds more clutter in
the UI. my 2c
On 11 Oct 2015 2:39 pm, "Dimitris Grammatiko" notifications@github.com
wrote:

Thanks Brian,

It’s the fever effect I guess

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/8064
http://issues.joomla.org/tracker/joomla-cms/8064.

—
Reply to this email directly or view it on GitHub
#8064 (comment).

@brianteeman I totally agree, I wouldn’t create the button if it would be displayed under the editor

Cool
On 11 Oct 2015 7:28 pm, "Dimitris Grammatiko" notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman I totally agree, I wouldn’t

create the button if it would be displayed under the editor

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/8064
http://issues.joomla.org/tracker/joomla-cms/8064.

—
Reply to this email directly or view it on GitHub
#8064 (comment).

I have tested this item successfully on fdec3ea

Works as advertised. I tried both inserting a specific module and a module position. Perfect results. Thank you, Dimitris!

I have tested this item successfully on fdec3ea

works as expected

RTC for 3.5. Thanks. :)

@dgt41
This is not multilanguage aware.
Can you filter the available modules in the popup by displaying only those tagged to the current language of the article edited and ALL languages when multilang is enabled?
A bit as we do for "forcedLanguage" but also adding ALL.

For the frontend, it looks possible by adding

        // Modal view should return only specific language and ALL
        if (JFactory::getApplication()->input->get('layout') == 'modal')
        {
            if (JFactory::getApplication()->isSite() && JLanguageMultilang::isEnabled())
            {
                $query->where('a.language in (' . $db->quote(JFactory::getLanguage()->getTag()) . ',' . $db->quote('*') . ')');
            }
        }

But for the backend, we would need to check first the language of the article, if already saved.
Any idea?

Corrected code above

@infograf768 I guess we can go away with the current status for the backend? Or we provide current state for not saved articles and do the extra filtering in the other occasion

Agree. Can you update PR?

Also, please add the update(s) sql and the new plugin in administrator/language/en-GB/install.xml

Back to pending

This PR has received new commits.

CC: @nikosdion, @rdeutz

@dgt41
Still missing:

Also, please add the update(s) sql and the new plugin in administrator/language/en-GB/install.xml

As well as the General install sql and the Script.php (com_admin)

This PR has received new commits.

CC: @nikosdion, @rdeutz

This PR has received new commits.

CC: @nikosdion, @rdeutz

I have tested this item successfully on ec43648

I have tested this item unsuccessfully on ec43648

I like this - seems far more useful than injecting an article.
Yes it's already possible, but adding a style is cool, and it's definitly simpler to use for newbies.
It worked as decsribed.

I have tested this item successfully on ec43648

I like this - seems far more useful than injecting an article.
Yes it's already possible, but adding a style is cool, and it's definitly simpler to use for newbies.
It worked as decsribed.

I have tested this item successfully on ec43648

Set to RTC. Leaving for @roland-d to merge into 3.5-dev

Thanks everybody, merged into 3.5-dev with commit 06f0d96

Another hair pulling merge :P