? ? Success

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
5 Oct 2015

Executive summary

A different solution for the problem in #7774

The Problem are PHP Warnings when no editor plugin available

Backwards compatibility

Full b/c, no problems are expected

Translation impact

1 new Language tag

Testing instructions

  • Disable all Editor plugins
  • Set Error Reporting to development
  • Create a new article
  • -> You should get PHP warning/notice *apply patch
  • Create a new article -> no warning and notices should appear
avatar rdeutz rdeutz - open - 5 Oct 2015
avatar rdeutz rdeutz - change - 5 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 5 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 5 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 5 Oct 2015
Category Administration UI/UX
avatar zero-24
zero-24 - comment - 5 Oct 2015

@rdeutz looks like the language string is missing ;)

8017_lang_string

avatar rdeutz
rdeutz - comment - 5 Oct 2015

I know I didn't add the langstring :-)

avatar infograf768
infograf768 - comment - 5 Oct 2015

Please alpha order the new string.

avatar zero-24 zero-24 - test_item - 6 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 6 Oct 2015

I have tested this item :white_check_mark: successfully on 09ae4a8
Works good here. But lets alpha order the new string ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8017.

avatar rdeutz
rdeutz - comment - 6 Oct 2015

@zero-24 So now I can remember why I always try to stay away from language files :-P

avatar zero-24 zero-24 - test_item - 6 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 6 Oct 2015

I have tested this item :white_check_mark: successfully on 256d92b

:smiley: I cna understand it ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8017.

avatar zero-24 zero-24 - change - 6 Oct 2015
Easy No Yes
avatar Fedik
Fedik - comment - 6 Oct 2015

hm, can we just display the textarea, it more logical no?
just thought :smile:

avatar rdeutz
rdeutz - comment - 6 Oct 2015

That was how it worked with the other patch, that would require to use the "none" - Editor plugin but this one is disabled so if we assume that this was done with a reason we shouldn't override the user choice.

avatar Fedik
Fedik - comment - 6 Oct 2015

I mean:

if (!$this->_editor)
{
  return '<textarea name="' . $name . '" cols="' . $col . '" rows="' . $row . '" >' . htmlspecialchars($html) . '</textarea>';
}
avatar rdeutz
rdeutz - comment - 6 Oct 2015

Never ever, this will return a string instead of an object and it isn't better at all because it still returns something that might not be expected.

avatar Fedik
Fedik - comment - 6 Oct 2015

JEditor::display() should return the string (editor markup) not object :wink:
well, ok, it was just an idea.

avatar alikon
alikon - comment - 7 Oct 2015

tested successfully

if we assume that this was done with a reason we shouldn't override the user choice.

agree

meanwhile testing this pr, even if this happens without this pr applied
i've the need to change something on Global Configuration (or just click the save button without any change)
in the condition that all Editor plugins are disabled, you are unable to save Global data....
so, not sure this is the correct behaviuor
we should allow for the same priciple "don't override user choice" to save Global data

avatar rdeutz
rdeutz - comment - 7 Oct 2015

@alikon I have noticed to same. This isn't related to this PR but I agree not great.

avatar alikon
alikon - comment - 7 Oct 2015

correct
i'm going to submit submit a new one

avatar zero-24 zero-24 - alter_testresult - 7 Oct 2015 - alikon: Tested successfully
avatar zero-24 zero-24 - change - 7 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 7 Oct 2015

RTC. Thanks i'm going to test the other PR now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8017.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 7 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-07 13:55:04
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - reference | 7764c4f - 7 Oct 15
avatar Kubik-Rubik Kubik-Rubik - merge - 7 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - close - 7 Oct 2015
avatar rdeutz rdeutz - head_ref_deleted - 7 Oct 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment