User tests: Successful: Unsuccessful:
A different solution for the problem in #7774
The Problem are PHP Warnings when no editor plugin available
Full b/c, no problems are expected
1 new Language tag
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Labels |
Added:
?
|
Milestone |
Added: |
Category | ⇒ | Administration UI/UX |
I know I didn't add the langstring :-)
Please alpha order the new string.
I have tested this item successfully on 09ae4a8
Works good here. But lets alpha order the new string ;)
I have tested this item successfully on 256d92b
I cna understand it ;)
Easy | No | ⇒ | Yes |
hm, can we just display the textarea
, it more logical no?
just thought
That was how it worked with the other patch, that would require to use the "none" - Editor plugin but this one is disabled so if we assume that this was done with a reason we shouldn't override the user choice.
I mean:
if (!$this->_editor)
{
return '<textarea name="' . $name . '" cols="' . $col . '" rows="' . $row . '" >' . htmlspecialchars($html) . '</textarea>';
}
Never ever, this will return a string instead of an object and it isn't better at all because it still returns something that might not be expected.
JEditor::display()
should return the string (editor markup) not object
well, ok, it was just an idea.
tested successfully
if we assume that this was done with a reason we shouldn't override the user choice.
agree
meanwhile testing this pr, even if this happens without this pr applied
i've the need to change something on Global Configuration (or just click the save button without any change)
in the condition that all Editor plugins are disabled, you are unable to save Global data....
so, not sure this is the correct behaviuor
we should allow for the same priciple "don't override user choice" to save Global data
correct
i'm going to submit submit a new one
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks i'm going to test the other PR now.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-07 13:55:04 |
Closed_By | ⇒ | Kubik-Rubik |
Labels |
Removed:
?
|
Milestone |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
@rdeutz looks like the language string is missing ;)