Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8016] - fixes overridebility of com_media

? Success

User tests: Successful: Unsuccessful:

avatar Webdongle
Webdongle
5 Oct 2015

Fixes administrator/components/com_media/views/images/tmpl/default.php override failing

Test instructions:

Apply this patch with patch tester
Go to protostar/html and create a folder com_media
Create another folder named images
Copy the content of the file administrator/components/com_media/views/images/tmpl/default.php to the newly created file
Edit the file so the first line above the first form tag to be <div><h1>This is a Protostar Override</h1></div>
Now try to login in the fronted and edit an article.
Go to Images and link and try to select an image
If you see the title This is a Protostar Override in the modal the you have a successful test!

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00
avatar Webdongle Webdongle - open - 5 Oct 2015
avatar Webdongle Webdongle - change - 5 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ?
avatar mbabker
mbabker - comment - 5 Oct 2015

In theory that would work. FWIW that code snippet changed here is what I'm
using in my own fork of the media manager without issue.

On Monday, October 5, 2015, Dimitris Grammatiko notifications@github.com
wrote:

@Webdongle https://github.com/Webdongle can you check my solution here:
https://github.com/joomla/joomla-cms/pull/5871/files#diff-46853d5c602b247ad0d2954fc28d7510

—
Reply to this email directly or view it on GitHub
#8016 (comment).

avatar zero-24 zero-24 - change - 5 Oct 2015
Category ⇒ Components
avatar zero-24 zero-24 - change - 5 Oct 2015
Title
…
Update controller.php
Update controller.php
avatar Webdongle
Webdongle - comment - 5 Oct 2015

@dgt41 does that fix the override issue

There are too many changes in that for me to replicate on localhost unless I use the patch tester on my local install

avatar dgt41
dgt41 - comment - 5 Oct 2015

@Webdongle Just tested your code with a protostar override and it did work nicely:
screenshot 2015-10-05 18 09 18

All the other changes in the file in my repo is just some CS work

avatar Webdongle
Webdongle - comment - 5 Oct 2015

@dgt41
@mbabker

Used patch-tester to pull 5871 to localhost test J3.4.4 ... FULL SUCCESS

Closing my patch

avatar Webdongle Webdongle - change - 5 Oct 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-05 15:14:50
Closed_By ⇒ Webdongle
avatar Webdongle Webdongle - close - 5 Oct 2015
avatar Webdongle Webdongle - close - 5 Oct 2015
avatar dgt41 dgt41 - change - 5 Oct 2015
The description was changed
Status Closed ⇒ Pending
Closed_Date 2015-10-05 15:14:50 ⇒
Closed_By Webdongle ⇒
avatar dgt41
dgt41 - comment - 5 Oct 2015

Set to "open" on behalf of @dgt41 by The JTracker Application at issues.joomla.org/joomla-cms/8016

avatar joomla-cms-bot joomla-cms-bot - reopen - 5 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - reopen - 5 Oct 2015
avatar dgt41
dgt41 - comment - 5 Oct 2015

@Webdongle Can you reopen this as the other PR is set to 3.5 and this can be accepted for the next minor version? In essence it is the same solution ????

avatar dgt41 dgt41 - test_item - 5 Oct 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 5 Oct 2015

I have tested this item :white_check_mark: successfully on eabbf50

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8016.

avatar soap soap - test_item - 5 Oct 2015 - Tested successfully
avatar soap
soap - comment - 5 Oct 2015

I have tested this item :white_check_mark: successfully on eabbf50

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8016.

avatar zero-24 zero-24 - change - 5 Oct 2015
Title
…
Update controller.php
fixes overridebility of com_media
Status Pending ⇒ Ready to Commit
Easy No ⇒ Yes
avatar zero-24
zero-24 - comment - 5 Oct 2015

RTC Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8016.

avatar zero-24 zero-24 - change - 5 Oct 2015
Title
…
Update controller.php
fixes overridebility of com_media
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - change - 6 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-06 19:28:20
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 6 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 6 Oct 2015
avatar rdeutz rdeutz - reference | 4237f8c - 6 Oct 15
avatar rdeutz rdeutz - merge - 6 Oct 2015
avatar rdeutz rdeutz - close - 6 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment