User tests: Successful: Unsuccessful:
Fix for #7999
install joomla from the current Staging in Github
Go to the first installation screen: Main Configuration
You will notice that the Site Offline button has a new look that is not right:
Before it was like:
This change happened in the last 24hours, I noticed because is breaking the automated tests (https://github.com/joomla-projects/joomla-browser/blob/develop/src/JoomlaBrowser.php#L152)
we would need this button to have back the default value as "no", and being able to change the values
"Site Offline" do not work. If you click you can't change the value anymore, is broken:
This happens in Firefox, Chrome, Safari and Opera in Mac and Ubuntu
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Rel_Number | 0 | ⇒ | 7999 |
Relation Type | ⇒ | Pull Request for |
the buttons after the patch:
Please also update the old copyrights: https://github.com/joomla/joomla-cms/pull/4022/files#diff-1a484eca2b31420444083dbca7198a81R6
I have tested this item successfully on efdeb8e
Works good here.
I have tested this item unsuccessfully on efdeb8e
This seems to fix the radio buttons for installation. However, #4022 has broken all radio buttons in backend. These buttons are not fixed for me with this PR.
Status | Pending | ⇒ | Ready to Commit |
RTC.
Lets do the codestyle and copyright updates do in a different PR there are more changes we need to do ;)
Labels |
Added:
?
|
The buttons are not selected with a default value. Additionally, when selecting a button, it is marked blue (primary) instead of green or red. And it is not possible to select the opposite value once you have selected a radio button.
Status | Ready to Commit | ⇒ | Pending |
back to pending. maybe because of the layout overrides for isis and protostar @okonomiyaki3000 ?
Labels |
Removed:
?
|
@Harmageddon can you try it with renamed folder administrator/templates/isis/html/layouts/joomla/fields
works for me for the backend (with this patch applyed as well)
same for frontend. /templates/protostar/html/layouts/joomla/fields
@okonomiyaki3000 do you know why you add thes overrides there?
Category | ⇒ | Administration Layout Libraries Templates (admin) Templates (site) |
Priority | Medium | ⇒ | Urgent |
Easy | No | ⇒ | Yes |
@okonomiyaki3000 here is a PR ( okonomiyaki3000#5) that fix all issues.
<field type="checkboxes" name="somefield" label="Select Some Stuff">
<option value="a" checked="true">A</option>
<option value="b">B</option>
<option value="c">C</option>
</field>
Thanks
@zero-24 This override template wraps the input tag inside of the label tag because that's the Bootstrap way. Of course, that applies to radio buttons that are meant to be rendered as radio buttons. To achieve the toggled button effect, Bootstrap provides a different solution using the button
tag. I suppose this override should be removed because the built-in Joomla templates are not really using Bootstrap in the standard way. That's unfortunate because it means there's not really an option of using normal radio buttons.
See okonomiyaki3000#5 that removes the overrides
This PR has received new commits.
CC: @Harmageddon, @javigomez, @zero-24
Alright, let's do that then. I hope future templates using Bootstrap 3 (or 4?) will work in a more standard way though.
I have tested this item successfully on cbb29cc
Thanks for the PR! Applied the patch and the buttons are back again! Also tested the installation an this patch works.
Hopefully this PS will be added soon!
I have tested this item successfully on cbb29cc
Patch works! Thank for the pr.
Status | Pending | ⇒ | Ready to Commit |
Thanks to the testers and @okonomiyaki3000 -> RTC
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-05 13:30:07 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Milestone |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
I have tested this item successfully on efdeb8e
I can confirm that the patch fixes the issue, now the radio buttons in /installation/ are back to normal:
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.