? Success
Pull Request for # 7999

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
2 Oct 2015

Fix for #7999


Steps to reproduce the issue

install joomla from the current Staging in Github

Go to the first installation screen: Main Configuration

You will notice that the Site Offline button has a new look that is not right:

screen shot 2015-10-02 at 02 44 55

Before it was like:

screen shot 2015-10-02 at 02 45 59

This change happened in the last 24hours, I noticed because is breaking the automated tests (https://github.com/joomla-projects/joomla-browser/blob/develop/src/JoomlaBrowser.php#L152)

Expected result

we would need this button to have back the default value as "no", and being able to change the values

Actual result

"Site Offline" do not work. If you click you can't change the value anymore, is broken:

screen shot 2015-10-02 at 02 51 06

System information (as much as possible)

This happens in Firefox, Chrome, Safari and Opera in Mac and Ubuntu

avatar okonomiyaki3000 okonomiyaki3000 - open - 2 Oct 2015
avatar okonomiyaki3000 okonomiyaki3000 - change - 2 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2015
Labels Added: ?
avatar javigomez javigomez - change - 2 Oct 2015
Rel_Number 0 7999
Relation Type Pull Request for
avatar javigomez javigomez - test_item - 2 Oct 2015 - Tested successfully
avatar javigomez
javigomez - comment - 2 Oct 2015

I have tested this item :white_check_mark: successfully on efdeb8e
I can confirm that the patch fixes the issue, now the radio buttons in /installation/ are back to normal:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar javigomez
javigomez - comment - 2 Oct 2015

the buttons after the patch:

screen shot 2015-10-02 at 04 48 18
screen shot 2015-10-02 at 04 48 18


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar javigomez
javigomez - comment - 2 Oct 2015
avatar zero-24 zero-24 - test_item - 2 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 2 Oct 2015

I have tested this item :white_check_mark: successfully on efdeb8e
Works good here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar Harmageddon Harmageddon - test_item - 2 Oct 2015 - Tested unsuccessfully
avatar Harmageddon
Harmageddon - comment - 2 Oct 2015

I have tested this item :red_circle: unsuccessfully on efdeb8e
This seems to fix the radio buttons for installation. However, #4022 has broken all radio buttons in backend. These buttons are not fixed for me with this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar zero-24 zero-24 - change - 2 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 2 Oct 2015

RTC.

Lets do the codestyle and copyright updates do in a different PR there are more changes we need to do ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2015
Labels Added: ?
avatar Harmageddon
Harmageddon - comment - 2 Oct 2015

screen shot 2015-10-02 at 05 00 00

The buttons are not selected with a default value. Additionally, when selecting a button, it is marked blue (primary) instead of green or red. And it is not possible to select the opposite value once you have selected a radio button.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar zero-24 zero-24 - change - 2 Oct 2015
Status Ready to Commit Pending
avatar zero-24
zero-24 - comment - 2 Oct 2015

back to pending. maybe because of the layout overrides for isis and protostar @okonomiyaki3000 ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2015
Labels Removed: ?
avatar zero-24
zero-24 - comment - 2 Oct 2015

@Harmageddon can you try it with renamed folder administrator/templates/isis/html/layouts/joomla/fields works for me for the backend (with this patch applyed as well)

avatar zero-24
zero-24 - comment - 2 Oct 2015

same for frontend. /templates/protostar/html/layouts/joomla/fields @okonomiyaki3000 do you know why you add thes overrides there?

avatar zero-24 zero-24 - alter_testresult - 2 Oct 2015 - zero-24: Tested unsuccessfully
avatar zero-24 zero-24 - change - 2 Oct 2015
Category Administration Layout Libraries Templates (admin) Templates (site)
avatar zero-24 zero-24 - change - 2 Oct 2015
Priority Medium Urgent
Easy No Yes
avatar zero-24 zero-24 - change - 2 Oct 2015
The description was changed
avatar Harmageddon
Harmageddon - comment - 2 Oct 2015

That's right, @zero-24. Without the overrides, it works.

avatar zero-24
zero-24 - comment - 2 Oct 2015

@okonomiyaki3000 here is a PR ( okonomiyaki3000#5) that fix all issues.

How to test (if my PR is merged into this)

  • install staging from this PR: https://github.com/okonomiyaki3000/joomla-cms/archive/fix-radiobuttons.zip (we need to wait for the merge of my pr above)
  • see the installation work (radio buttons)
  • go to the backend e.g. the global config see the radio buttons works as bevor
  • go to frontend (e.g. site-settings) and see the radio also works there.
  • apply the following code to ( plugins/user/profile/profiles/profile.xml)
<field type="checkboxes" name="somefield" label="Select Some Stuff">
   <option value="a" checked="true">A</option>
   <option value="b">B</option>
   <option value="c">C</option>
</field>
  • enable profiel plugin
  • see the profile in backend --> works
  • see the profile in frontend --> works

Thanks :smile:

avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Oct 2015

@zero-24 This override template wraps the input tag inside of the label tag because that's the Bootstrap way. Of course, that applies to radio buttons that are meant to be rendered as radio buttons. To achieve the toggled button effect, Bootstrap provides a different solution using the button tag. I suppose this override should be removed because the built-in Joomla templates are not really using Bootstrap in the standard way. That's unfortunate because it means there's not really an option of using normal radio buttons.

avatar zero-24
zero-24 - comment - 5 Oct 2015

See okonomiyaki3000#5 that removes the overrides ????

avatar joomla-cms-bot
joomla-cms-bot - comment - 5 Oct 2015

This PR has received new commits.

CC: @Harmageddon, @javigomez, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Oct 2015

Alright, let's do that then. I hope future templates using Bootstrap 3 (or 4?) will work in a more standard way though.

avatar RickR2H RickR2H - test_item - 5 Oct 2015 - Tested successfully
avatar RickR2H
RickR2H - comment - 5 Oct 2015

I have tested this item :white_check_mark: successfully on cbb29cc
Thanks for the PR! Applied the patch and the buttons are back again! Also tested the installation an this patch works.
Hopefully this PS will be added soon!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar YouriiM26 YouriiM26 - test_item - 5 Oct 2015 - Tested successfully
avatar YouriiM26
YouriiM26 - comment - 5 Oct 2015

I have tested this item :white_check_mark: successfully on cbb29cc
Patch works! Thank for the pr.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar zero-24 zero-24 - change - 5 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 5 Oct 2015

Thanks to the testers and @okonomiyaki3000 :smile: -> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8000.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 5 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - close - 5 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 5 Oct 2015
avatar rdeutz rdeutz - reference | f46308d - 5 Oct 15
avatar rdeutz rdeutz - merge - 5 Oct 2015
avatar rdeutz rdeutz - change - 5 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-05 13:30:07
Closed_By rdeutz
avatar rdeutz rdeutz - close - 5 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Removed: ?
avatar zero-24
zero-24 - comment - 5 Oct 2015

@RickR2H

Hopefully this PS will be added soon!

Nothing is / was broken in any stable release. Just the staging branch had this problem ;)

avatar RickR2H
RickR2H - comment - 5 Oct 2015

@zero-24 Glad to hear that ;)

avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 25 Jan 2016

Add a Comment

Login with GitHub to post a comment