?
Referenced as Pull Request for: # 8000
avatar javigomez
javigomez
2 Oct 2015

Steps to reproduce the issue

install joomla from the current Staging in Github

Go to the first installation screen: Main Configuration

You will notice that the Site Offline button has a new look that is not right:

screen shot 2015-10-02 at 02 44 55

Before it was like:

screen shot 2015-10-02 at 02 45 59

This change happened in the last 24hours, I noticed because is breaking the automated tests (https://github.com/joomla-projects/joomla-browser/blob/develop/src/JoomlaBrowser.php#L152)

Expected result

we would need this button to have back the default value as "no", and being able to change the values

Actual result

"Site Offline" do not work. If you click you can't change the value anymore, is broken:

screen shot 2015-10-02 at 02 51 06

System information (as much as possible)

This happens in Firefox, Chrome, Safari and Opera in Mac and Ubuntu

avatar javigomez javigomez - open - 2 Oct 2015
avatar infograf768
infograf768 - comment - 2 Oct 2015

We lost the class="btn-group btn-group-yesno"

avatar zero-24
zero-24 - comment - 2 Oct 2015

@okonomiyaki3000 can you have a look here? Looks like that happens because of this (now merged) PR: #4022?

avatar zero-24
zero-24 - comment - 2 Oct 2015

Restoring this file (/libraries/joomla/form/fields/radio.php) from: https://raw.githubusercontent.com/joomla/joomla-cms/3.4.4/libraries/joomla/form/fields/radio.php gets the install working as before.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Oct 2015

I don't know why the layout was putting radios inside of a list.. Was it like that years ago when I first made this pr or did I add it because I'm insane? We may never know. Unless we try to find out. But let's not care about that now. This fix should fix it.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Oct 2015

If not, I'll have a look on monday.

avatar zero-24 zero-24 - change - 2 Oct 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-10-02 09:58:24
Closed_By zero-24
avatar zero-24
zero-24 - comment - 2 Oct 2015

Closing as we have a PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7999.

avatar zero-24 zero-24 - close - 2 Oct 2015

Add a Comment

Login with GitHub to post a comment