[#798] - [#30274] JFormValidator JavaScript class does not scale well
- Closed
- 18 Nov 2013
- Medium
- Build: master
- # 798
- Diff
- rmcdaniel:30274
- Foreign ID 30274
User tests: Successful: Unsuccessful:
Joomla!'s JFormValidator JavaScript class does not scale well with large numbers
of form elements. The reason for this is that the handleResponse() method loops
through every label each time it is called. Instead of this, I have modified
the code to do this only once and store the results for future use.
Here is the relevant forum post:
http://forum.joomla.org/viewtopic.php?p=3002410#p3002410
Here is the issue tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=30274
We have two confirmed tests now. The patch works.
What is the current status of this PR? I does need to be updated with staging to be merged, but is there anything else stopping it?
I was under the impression that pull requests before a certain date didn't have to be resubmitted to staging.
Yes, you are right, it does not need to be resubmitted against staging, but it is no longer in synch. It needs to be updated with the latest changes so it can be merged.
It looks like I'll have to resubmit the pull request anyways because this needs to go in 2.5.x not master.
Yes, you are correct. My apologies for not noticing that. I'm going to close this issue then.
Testing went well. Any idea on if/when this will be accepted?