Feeling Lucky
?
[#7960] - CLEANING-JFeed
- Closed
- 8 May 2016
- Medium
- Build: staging
- # 7960
- Diff
- Mathewlenning:CLEANING-JFeedFactory
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Removed a redundant Else clause from JFeedFactory::getFeed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
Kubik-Rubik
- comment
- 8 May 2016
Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. I will close this PR now. If you want to update your PR, then this can be re-opened.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7960.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 09:49:14 |
| Closed_By | ⇒ | Kubik-Rubik |
Can you update this branch to latest staging? If that is done, I would like to request that a maintainer does a codereview and then merges this PR. This is otherwise untestable for a "normal" user and would stay in limbo forever. I can say that the code is good and that our almost 100% unittest coverage also agrees with that.