? ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
27 Sep 2015

This just ports two minor unit tests improvements. First is to check for an instance of JDatabaseDriver rather than the deprecated JDatabase in the JAdapter unit test (in all other places in our test suite we check for JDatabaseDriver so this makes things consistent).

It also removes a require of the JString package. JString is autoloaded - so this require is completely unnecessary

avatar wilsonge wilsonge - open - 27 Sep 2015
avatar wilsonge wilsonge - change - 27 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 28 Sep 2015
Category Unit Tests
avatar zero-24
zero-24 - comment - 28 Sep 2015

@wilsonge as we get a ok by travis we can RTC?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7959.

avatar wilsonge
wilsonge - comment - 28 Sep 2015

In my opinion yes :P

avatar zero-24 zero-24 - change - 28 Sep 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 28 Sep 2015

Done.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7959.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2015
Labels Added: ?
avatar mbabker mbabker - change - 28 Sep 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-09-28 13:13:38
Closed_By mbabker
avatar mbabker mbabker - reference | 9c37b27 - 28 Sep 15
avatar mbabker mbabker - merge - 28 Sep 2015
avatar mbabker mbabker - close - 28 Sep 2015
avatar zero-24 zero-24 - change - 28 Sep 2015
Milestone Added:
avatar wilsonge wilsonge - head_ref_deleted - 28 Sep 2015
avatar zero-24 zero-24 - change - 2 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment