@thongredweb can you add a quick test szenario? Else i guess we don't get any testers here on this.

Test case:

• In any other extensions
• Use class JImage for generate thumbnail file. $jimage = new JImage
• Use method setThumbnailGenerate for set quality of thumbnail generated file.

$jimage->setThumbnailGenerate(true); // For best quality

$jimage->setThumbnailGenerate(false); // For best speed

This code has been tested successfully due to this PR #7857. This PR just for move this option into JImage class not from Joomla Configuration. The purpose is for other extensions can decide to choose quality or speed when use JImage class for generate thumbnail of images.

As the code is different it needs new tests

I have tested this item ✅ successfully on b38b65d

Tested using:

$jimage = new JImage('/var/www/html/joomla-hc/administrator/components/com_helloworld/bild.jpg');
$jimage->setThumbnailGenerate(false); //or true
$jimage->createThumbs("250x250",3,"/var/www/html/testout/");

true generated better images.

@icampus

I have tested this item ? unsuccessfully on b38b65d

I tried it with png and jpeg and doesnt saw a great difference.
I used the following code to test it:

$jimage = new JImage('images/bild_normal.jpeg');
$jimage->setThumbnailGenerate(false); //or true
$jimage->createThumbs("250x250",3,"images");

I tested it once without the patch, then apllied the patch, and tested it with the parameter false and another time with the parameter true.
Tested@icampus

RTC as we have 2 successful tests

@roland-d but we also have a failed test

@brianteeman I have reset the test to successful as we discussed the result here and the test is actually OK. Depending on the option selected you get a different kind of image as explained in the instructions. Not seeing a whole lot of difference between images isn't necessarily an unsuccessful test. Someone else is going to test it as well just to be sure.

OK - thanks

On 2 August 2016 at 14:31, RolandD notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I have reset the test to
successful as we discussed the result here and the test is actually OK.
Depending on the option selected you get a different kind of image as
explained in the instructions. Not seeing a whole lot of difference between
images isn't necessarily an unsuccessful test. Someone else is going to

test it as well just to be sure.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/7919
https://issues.joomla.org/tracker/joomla-cms/7919.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7919 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bcvNBMBIXlf3Bq5fqZHTEOHQvHbks5qb0aZgaJpZM4GAsKx
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Merged with 0ba5a11 - thanks :)