? ? Success
Referenced as Pull Request for: # 7919

User tests: Successful: Unsuccessful:

avatar thongredweb
thongredweb
11 Sep 2015

Allow admin can choose which way they want when generate thumbnail image of JImage class.

  • Best quality but more speed.
  • Fastest speed but not good quality (pixelated bug).
avatar thongredweb thongredweb - open - 11 Sep 2015
avatar thongredweb thongredweb - change - 11 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2015
Status Pending New
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2015
Status New Pending
avatar Bakual
Bakual - comment - 11 Sep 2015

Imho, that should be an extension specific setting and not a global one.

avatar infograf768
infograf768 - comment - 11 Sep 2015

If considered, please alpha order new string
+COM_CONFIG_THUMBNAIL_SETTINGS="Image Thumbnail Settings"

avatar wilsonge
wilsonge - comment - 11 Sep 2015

I agree with @Bakual at best this should be a constructor parameter (add a $options array which makes this easier). Then it's down to the extension to initialise as appropriate. It's definitely NOT something to be set in the application

To be honest I'm not even sure if it should be a function specific parameter (you might want to resize an image in good quality at large resolutions and low quality at smaller, for example)

avatar zero-24 zero-24 - change - 11 Sep 2015
Labels Removed: ?
avatar Bakual Bakual - close - 11 Sep 2015
avatar Bakual
Bakual - comment - 11 Sep 2015

Closing this PR as it will not be merged in this form.
Feel free to propose something in the class itself which can be used by the extensions.

avatar Bakual Bakual - change - 11 Sep 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-09-11 13:35:30
Closed_By Bakual
avatar javigomez
javigomez - comment - 14 Sep 2015

I'm not sure witch is the right solution but I have tested this and there is an error in the way JImage generates png thumbnails, ending in pixelated results. And with Thong's way the thumb looks good.

Linking here Roberto's comment redCOMPONENT-COM/redCORE#548 (comment)

avatar wilsonge
wilsonge - comment - 14 Sep 2015

I agree that this needs fixing. But setting it at the JFactory level is 100% wrong. As I said I think it should be at the function level - but if people want it at the class level like i said I could understand it.

Add a Comment

Login with GitHub to post a comment