? Success

User tests: Successful: Unsuccessful:

avatar Devportobello
Devportobello
18 Sep 2015

Summary

Form field menuitem doesnt indicate language of an item.

Important thing

This PR could conflict with #7148

Test

  • Create many menuitem with different language
  • Enable plugin "System - Language Filter "
  • Create menu module and use " Base Item"
  • Unable to know language of menuitem
  • Apply patch
  • Now you can know language of menuitem

Other

I wanted to add flag picture but choosen dont allow that :/

Preview

Preview

avatar Devportobello Devportobello - open - 18 Sep 2015
avatar Devportobello Devportobello - change - 18 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 18 Sep 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 18 Sep 2015
Easy No Yes
avatar infograf768
infograf768 - comment - 19 Sep 2015

No use to define a new variable
$multilangIsEnabled = JLanguageMultilang::isEnabled();

Please use the existing JLanguageMultilang::isEnabled() directly.

avatar Devportobello Devportobello - change - 21 Sep 2015
The description was changed
avatar Devportobello
Devportobello - comment - 21 Sep 2015

You right, not noticed multilang already cached.

avatar degobbis degobbis - test_item - 24 Oct 2015 - Tested successfully
avatar degobbis
degobbis - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 0783009


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7905.

avatar degobbis degobbis - test_item - 24 Oct 2015 - Tested successfully
avatar degobbis
degobbis - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 0783009


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7905.

avatar farrelljsec farrelljsec - test_item - 24 Oct 2015 - Tested successfully
avatar farrelljsec
farrelljsec - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 0783009

Test is sucsessfull. But why do you get a.published you donĀ“t use?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7905.

avatar yvesh yvesh - test_item - 24 Oct 2015 - Tested successfully
avatar yvesh
yvesh - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 0783009

Test is successful - code could be improved a bit (you added a.published, which you don't use)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7905.

avatar yvesh yvesh - test_item - 24 Oct 2015 - Tested successfully
avatar yvesh yvesh - test_item - 24 Oct 2015 - Tested successfully
avatar SniperSister SniperSister - change - 24 Oct 2015
Status Pending Needs Review
avatar SniperSister
SniperSister - comment - 24 Oct 2015

@rdeutz please make a decision if this can be merged regardless of the unnecessary select


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7905.

avatar Devportobello
Devportobello - comment - 26 Oct 2015

@yvesh @rdeutz you right, i copied code for this helper from another PR: #7904 which introduce this select.
Dunno what i need to do.

avatar brianteeman brianteeman - change - 21 Mar 2016
Category Administration UI/UX Administration Multilanguage UI/UX
avatar Devportobello Devportobello - change - 6 Apr 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-04-06 10:04:18
Closed_By Devportobello
avatar Devportobello Devportobello - close - 6 Apr 2016

Add a Comment

Login with GitHub to post a comment