? ? Success

User tests: Successful: Unsuccessful:

avatar Devportobello
Devportobello
18 Sep 2015

Summary

When you create/edit module, you can select page where module only show.
All menuitem are listed without knowing if item are published or not and without language if multilang enabled.

Test

  • Create many menuitem as parent and many child
  • Unpublish some menuitem
  • Create custom module and goto menu assignment, select "Only on the pages selected"
  • Unable to know if menuitem published or not
  • Set many menuitem in different language
  • Enable plugin "System - Language Filter "
  • Goto module, all menuitem dont include langcode or flag
  • Apply patch
  • Now you can know if menuitem is unpublished and language

Preview

Version 1

Preview

Version 2

Preview

Version 3 - actual commit

Preview

avatar Devportobello Devportobello - open - 18 Sep 2015
avatar Devportobello Devportobello - change - 18 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2015
Labels Added: ?
avatar Devportobello Devportobello - change - 18 Sep 2015
The description was changed
fda06d3 18 Sep 2015 avatar Devportobello CS
avatar zero-24 zero-24 - change - 18 Sep 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 18 Sep 2015
Easy No Yes
avatar Devportobello Devportobello - change - 18 Sep 2015
Title
[UX] Module menu assignment unpublished item
[UX] Module menu assignment improvement
avatar Devportobello Devportobello - change - 18 Sep 2015
The description was changed
Title
[UX] Module menu assignment unpublished item
[UX] Module menu assignment improvement
avatar infograf768
infograf768 - comment - 19 Sep 2015

Nice. Tested OK here.

avatar crystalenka
crystalenka - comment - 19 Sep 2015

Works as intended, but would suggest maybe adding something to clarify what the red 'x' means - I have a hunch people won't know that means the menu item is unpublished.

Maybe something like this?

screen shot 2015-09-19 at 14 42 42


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7904.

avatar crystalenka crystalenka - test_item - 19 Sep 2015 - Tested successfully
avatar jayblaq
jayblaq - comment - 19 Sep 2015

Confirmed that it works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7904.

avatar jayblaq jayblaq - test_item - 19 Sep 2015 - Tested successfully
avatar zero-24 zero-24 - alter_testresult - 19 Sep 2015 - infograf768: Tested successfully
avatar zero-24 zero-24 - change - 19 Sep 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 19 Sep 2015

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7904.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 20 Sep 2015

We could easily get a tooltip at no big cost for the unpublished icon if judged necessary.
Code would be:

<?php if ($link->published == 0) : ?><span title="<?php echo JText::_('JUNPUBLISHED'); ?>" class="icon icon-unpublish hasTooltip"></span><?php endif;?>

screen shot 2015-09-20 at 08 27 29

avatar Bakual
Bakual - comment - 20 Sep 2015

Or we could use a label after the menu title instead of the icon similar to what we do in frontend for unpublished items. <span class="label><?php echo JText::_('JUNPUBLISHED'); ?></span>
I agree the icon alone would be not clear enough.

avatar Hils
Hils - comment - 20 Sep 2015

Should the 'delete' icon be used as an 'unpublish' icon? Unpublish is reversible and, normally, delete isn't so it could cause confusion.

avatar Bakual
Bakual - comment - 20 Sep 2015

Should the 'delete' icon be used as an 'unpublish' icon? Unpublish is reversible and, normally, delete isn't so it could cause confusion.

It's the icon that is on every "unpublish" button in backend and in the state icon in the backend lists indicating unpublished items. The delete buttons have the trash icon. So it is the correct icon. I'm just not sure if it's self-explanatory in the context of that view.

avatar Devportobello Devportobello - change - 21 Sep 2015
The description was changed
avatar Devportobello
Devportobello - comment - 21 Sep 2015

I agree, "red X" doesnt really clear.
Updated, like frontend.

avatar jayblaq
jayblaq - comment - 21 Sep 2015

Perhaps just changing the color of the text or a strike would be better with a tooltip?

Sent from my iPhone

On Sep 21, 2015, at 3:18 AM, Devportobello notifications@github.com wrote:

I agree, "red X" doesnt really clear.
Updated, like frontend.


Reply to this email directly or view it on GitHub.

avatar Fedik
Fedik - comment - 22 Sep 2015

I have thought:
Can do all additional labels After the Menu title?
because in the big menu it already to much work for Eyes, and if start placing the icons/labels on the front of the title then it can be a "hard" appearance.

Bad:

  • Title1
  • * Title2
  • Title3
  • * Title4

Good:

  • Title1
  • Title2 *
  • Title3
  • Title4 *

Then it can be simple text label (after the lang flag) instead of icon.

avatar Devportobello Devportobello - change - 22 Sep 2015
The description was changed
avatar Devportobello
Devportobello - comment - 22 Sep 2015

Updated.
Added each screen per version.

avatar Bakual
Bakual - comment - 22 Sep 2015

Last iteration looks best to me. Thanks!

avatar Fedik
Fedik - comment - 22 Sep 2015

:+1:

avatar dgt41
dgt41 - comment - 22 Sep 2015

@test ok

avatar zero-24 zero-24 - change - 23 Sep 2015
Milestone Added:
avatar zero-24 zero-24 - change - 23 Sep 2015
Milestone Added:
avatar rdeutz rdeutz - change - 1 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - change - 1 Oct 2015
Milestone
avatar rdeutz rdeutz - change - 1 Oct 2015
Labels Added: ?
avatar roland-d roland-d - reference | 4497426 - 3 Oct 15
avatar roland-d roland-d - close - 3 Oct 2015
avatar roland-d
roland-d - comment - 3 Oct 2015

Thank you for your contribution. Added to 3.5-dev branch with commit 4497426.

avatar roland-d roland-d - change - 3 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-03 16:34:53
Closed_By roland-d
avatar roland-d roland-d - close - 3 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 3 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2015
Labels Removed: ?
avatar Devportobello Devportobello - head_ref_deleted - 26 Oct 2015

Add a Comment

Login with GitHub to post a comment