[#7892] - Fix undefined notice message
- Closed
- 1 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7892
- Diff
- Bakual:FixUndefinedNoticeMessage
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR proposes a better fix than #7884
Issue
If an extension uses a custom message type in the enqueueMessage($message, $type) method, then it will currently show a notice:
Notice: Undefined index: foo in ...\templates\protostar\html\layouts\joomla\system\message.php`
Solution
Check first if the array key is set before calling it. If not set, just use the $type directly.
Testing
Simplest is to just add the following line to the start of the index.php of the template:
JFactory::getApplication()->enqueueMessage('test', 'success'); (should create a green message)
or
JFactory::getApplication()->enqueueMessage('test', 'foo'); (should create a orange message)
Note
The Isis template uses the same JLayout, so I changed it there as well.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
degobbis
- | Category | ⇒ | Layout |
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-01 18:36:24 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
Tested successful. Together with the test by @degobbis I'm going to mark it RTC. Thanks @Bakual and @degobbis
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7892.