Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7806] - Fixes wrong behaviour in filter method of JForm class

? Success

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
2 Sep 2015

This PR fixes the problem that was introduced in this PR #7381. The mentioned PR produces a major bug (Installation process is not possible any more / Form submitting can lead to data loss, see #7799 (comment)). Additionally this PR restores the default behaviour that if a default value is set in a multiple checkbox, then it should also be taken into account (see #7799 (comment)).

It will also solve problems with the validation process because we do not set an empty array as default value (Issue #7316).

How and what to test

Installation process of version 3.4.4 RC

  1. Download the full package of the RC version (https://github.com/joomla/joomla-cms/releases/tag/3.4.4-rc)
  2. Unzip it locally and do the changes from this PR
  3. Start the installation process and verify that it runs properly

Intro image in frontend editing

  1. Create a new article and assign an intro image
  2. Sign in into the frontend and edit the article (e.g. change title)
  3. After the save the intro image should still be available
avatar Kubik-Rubik Kubik-Rubik - open - 2 Sep 2015
avatar Kubik-Rubik Kubik-Rubik - change - 2 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 2 Sep 2015
Category ⇒ Installation Libraries
avatar Kubik-Rubik Kubik-Rubik - change - 2 Sep 2015
Priority Medium ⇒ Critical
Easy No ⇒ Yes
avatar Kubik-Rubik
Kubik-Rubik - comment - 2 Sep 2015

Increased priority to "Critical" because the fixed bug is a release blocker.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7806.

avatar alikon
alikon - comment - 3 Sep 2015

followed your "how and what" info's and able to install, able to create and change (from frontend) an intro image to an article, but no fantasy to think at other possible tests to check

avatar RickR2H RickR2H - test_item - 3 Sep 2015 - Tested successfully
avatar RickR2H
RickR2H - comment - 3 Sep 2015

PR works!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7806.

avatar Fedik Fedik - test_item - 3 Sep 2015 - Tested successfully
avatar Fedik
Fedik - comment - 3 Sep 2015

Intro image works now :smile:
thanks :wink:

avatar ghazal
ghazal - comment - 3 Sep 2015

Installation bug confirmed.
PR works.

avatar zero-24 zero-24 - alter_testresult - 3 Sep 2015 - alikon: Tested successfully
avatar zero-24 zero-24 - change - 3 Sep 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 3 Sep 2015

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7806.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2015
Labels Added: ?
avatar Bakual Bakual - change - 3 Sep 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-09-03 09:51:18
Closed_By ⇒ Bakual
avatar Bakual Bakual - close - 3 Sep 2015
avatar joomla-cms-bot joomla-cms-bot - close - 3 Sep 2015
avatar Bakual Bakual - reference | abcc0eb - 3 Sep 15
avatar Bakual Bakual - merge - 3 Sep 2015
avatar Bakual Bakual - close - 3 Sep 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 3 Sep 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment