?
avatar MonkeyTrainer12
MonkeyTrainer12
2 Sep 2015

Steps to reproduce the issue

Not really a bug, but a common problem.

Displaying RSS feeds using com_newsfeed, many providers mistakenly use relative addressing to display images.

Expected result

A feed display which includes imagery.

Actual result

A feed display which includes numerous broken image links.

System information (as much as possible)

I built a simple fix for Joomla 3.x

Additional comments

It's an easy fix. Add the following lines immediately before line 126 (the echo statement which prints the $text variable):

$domain = preg_replace( "~^(https?://[^/]).$~", "\1/", $this->rssDoc[ $i ]->uri );
$text = str_replace( ' src="/', ' src="' . $domain, $text );

I'm currently supplying sites with an override html template which works fine, but I would prefer if this minor cleanup was included in the default Joomla Install.

avatar MonkeyTrainer12 MonkeyTrainer12 - open - 2 Sep 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Sep 2015

Please create a Pull Request (PR) with your suggested solution, then we can test it! Example with the GitHub UI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7805.

avatar conconnl
conconnl - comment - 26 Jun 2016

@MonkeyTrainer12 can you please create a Pull Request, so we can test it for you and merge it into the core?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7805.

avatar brianteeman
brianteeman - comment - 3 Aug 2016

Closed as we have a PR for testing #11414


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7805.

avatar brianteeman brianteeman - change - 3 Aug 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-08-03 13:10:30
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Aug 2016

Add a Comment

Login with GitHub to post a comment