[#780] - Fixed 'You Are Here' toggle
- Closed
- 2 Mar 2014
- Medium
- Build: master
- # 780
- Diff
- matthewtbaker:patch-1
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
Added additional JTEXT('MOD_BREADCRUMBS_HERE') to allow user to toggle whether 'You Are Here: ' is shown within the span or not. The current release does not show the YAH text.
Thanks guys! Looks like we have a duplicate. Please see:
#872
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30371
Yep, so other one can get closed...
We'll just keep both open and count the tests on both as one, then close both when the issue is resolved in master.
I believe one of these PR's should be updated as the CSS span identifier used here specifically references the icon. The Language string should not be included within this span, but in a separate span. I think I have referenced this in the Tracker URL listed by Nick above.
I tested both patches (780 & 872)... same code, same consequences (see screenshot)
This is just my opinion but I've never found that the phrase "You are here" is very useful
Tested: positive!