[#779] - [#29767] fixes a bug in smart search categoryAccessChange.
- Closed
- 19 Oct 2014
- Medium
- Build: 2.5.x
- # 779
- Diff
- julienV:fix-finder-adapter-25x
- Foreign ID 29767
User tests: Successful: Unsuccessful:
The current implementation will reindex the same category over and over in the
loop instead of the 'items' of the category.
Note that this function is buggy anyway in the way it handles the access level
for items and category with a 'max' (access level have no reason to be ordered by id !)
issue tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29767
Tested and works as expected, but you are also right that it does not handle the access levels correctly.
And with the words of Cato the Elder: Ceterum censeo Joomlacode esse delendam (I believe that Joomlacode has to be destroyed. ;-) )
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | Search |
| Labels |
Added:
?
|
||
@test I have tested issue without any patch, steps I followed, are mentioned below, And I cant reproduce this mentions error.
Steps:
1) Installed fresh joomla 2.5.8
2) created a new category under public access
3) created an article in newly created category (under public access)
4) went to front end search for a category and an article without log in
5) I get both article and category in search result
6) now, I change category access from public to register
7) and I search same thing again
8) I get empty search result, which i think is a correct behavior
Please correct me, I dint follow your steps correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/779.
@Ronak please test with the latest release of 2.5 which is NOT 2.5.8
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/779.
@test I have installed fresh joomla 2.5.27 and followed above steps which have been mentioned by me in above comment,
I get correct output And I cant reproduce this mentions error.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/779.
Could a repo maintainer look at this? In the end, this is a no-brainer, since there is no $row variable in that context and thus this only throws an error and nothing else. This PR is the correct fix for that.
| Status | Pending | ⇒ | Needs Review |
| Title |
|
||||||
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-19 03:47:06 |
| Title |
|
||||||
please @julienV create a tracker item and cross reference it here in a comment. Thanks