Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7718] - [codestyle] Removed redundant elses

? Pending

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
17 Aug 2015

This PR Removes redundant elses that contain returns in the previous if.
/components/com_users/controllers/user.php

avatar nonumber nonumber - open - 17 Aug 2015
avatar nonumber nonumber - change - 17 Aug 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 18 Aug 2015
Status Pending ⇒ Ready to Commit
avatar zero-24 zero-24 - change - 18 Aug 2015
Category ⇒ Code style
avatar zero-24
zero-24 - comment - 18 Aug 2015

Looks good thanks @nonumber

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7718.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 18 Aug 2015
Category Code style ⇒ Front End
avatar zero-24 zero-24 - change - 18 Aug 2015
Status Ready to Commit ⇒ Pending
Easy No ⇒ Yes
avatar zero-24
zero-24 - comment - 18 Aug 2015

As we change the logic and not only simple CS. I just remove the RTC but mark my successful test. On really codestyle fixes we don't need tests but as we change the logic here we need tests. Just that all looks good as a simple Code Review is not easy possible.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7718.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2015
Labels Removed: ?
avatar ceus1984 ceus1984 - test_item - 24 Oct 2015 - Tested successfully
avatar ceus1984
ceus1984 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on aa7ae64

Tested Login and Logout. Wrong password and "Rememberme" Cookie

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7718.

avatar zero-24
zero-24 - comment - 24 Oct 2015

@nonumber Can you rebase here? Than i can set it RTC. Thanks

avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Oct 2015

This PR has received new commits.

CC: @ceus1984

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7718.

avatar nonumber
nonumber - comment - 24 Oct 2015

Sorry for the mucking around. Have switched from Windows to a Mac a few weeks ago. So still figuring out the new workflow for github :S

avatar zero-24 zero-24 - test_item - 25 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 25 Oct 2015

I have tested this item :white_check_mark: successfully on adb44f2

Just tested again the rebased version. Thanks @nonumber

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7718.

avatar zero-24 zero-24 - change - 25 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 25 Oct 2015
Milestone Added:
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 25 Oct 2015

RTC. Thanks. Mave fun with your new Mac :smiley:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7718.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - close - 27 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 27 Oct 2015
avatar rdeutz rdeutz - reference | 637f007 - 27 Oct 15
avatar rdeutz rdeutz - merge - 27 Oct 2015
avatar rdeutz rdeutz - close - 27 Oct 2015
avatar rdeutz rdeutz - change - 27 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-27 21:05:02
Closed_By ⇒ rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Removed: ?
avatar nonumber nonumber - head_ref_deleted - 27 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment