? ? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
17 Aug 2015

This PR moves Filters from left sidebar to Search Tools.

Testing instructions

You have to install some old extensions for which newer versions are available. Make sure that you install extensions with different Type / Folder / Client so that you can test the various settings of the Filters.

For my tests with Update I chose the following extensions because I use them often and I had some old versions available:
Name | Type | Version | Folder | Client
Akeeba Backup | Component | 4.0.5 | N/A | Administrator
DJ-ImageSlider Package | Package | 2.2.4 | N/A | Site
JCE Editor | Component | 2.4.3 | N/A | Administrator
JCE MediaBox (J2.5 - 3) | Plugin | 1.1.17 | system | Site

For my test with Discover I copied the templateDetails.xml of an admin and a site template,
and the .xml manifest file of an authentication Plugin,
and changed those to get some fake extensions that Joomla could discover to install.

Before this PR

Extensions > Manage > Update

  1. Left sidebar has 3 filter options (Select: Location, Type, Folder) that cannot be reset easily to original state with one button.

extension-update

Extensions > Manage > Discover

  1. Left sidebar has 3 filter options (Select: Location, Type, Folder) that cannot be reset easily to original state with one button.

extension-discover

Extensions > Manage > Discover & clicked on [Discover] button

  1. Left sidebar has 3 filter options (Select: Location, Type, Folder) that cannot be reset easily to original state with one button.

extension-discover-before

After this PR

Extensions > Manage > Update

  1. The Filters have been moved from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button. Note: the Filters work okay because the lists are filtered on basis of those filters. However the filters do not keep their chosen value. I hope that someone else understands the problem and can fix that.

extension-update-after

Extensions > Manage > Discover

  1. The Filters have been moved from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button.

extension-discover-after

Extensions > Manage > Discover & Search Tools + Select Type Option has been clicked

  1. The Filters have been moved from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button. Note: these Filters work okay and they keep their chosen value.

extension-discover-after-selected

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar pe7er pe7er - open - 17 Aug 2015
avatar pe7er pe7er - change - 17 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 17 Aug 2015

I added $this->setState('list.ordering', 'name'); to both models (update & discover models) to prevent errors.

avatar zero-24 zero-24 - change - 18 Aug 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 18 Aug 2015
Easy No Yes
avatar watchfulli-dev
watchfulli-dev - comment - 20 Aug 2015

@test after applying the patch, now the left filters are moved on top inside the Search tools, and applying the filters works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7717.

avatar watchfulli-dev watchfulli-dev - test_item - 20 Aug 2015 - Tested successfully
avatar hitchblade
hitchblade - comment - 20 Aug 2015

Works great, Looks better.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7717.

avatar hitchblade hitchblade - test_item - 20 Aug 2015 - Tested successfully
avatar kesh52 kesh52 - test_item - 20 Aug 2015 - Tested successfully
avatar pe7er
pe7er - comment - 20 Aug 2015

Thanks for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7717.

avatar zero-24 zero-24 - change - 23 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 23 Aug 2015

Moving to RTC. Thanks @pe7er and the testers :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7717.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar wilsonge wilsonge - change - 23 Sep 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 2 Nov 2015

Smae here :( Again merge conflicts @pe7er

avatar pe7er
pe7er - comment - 3 Nov 2015

Please see new PR #8263 to replace this one.

avatar pe7er pe7er - change - 3 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-03 22:19:55
Closed_By pe7er
avatar pe7er pe7er - close - 3 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 3 Nov 2015
avatar pe7er pe7er - close - 3 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 4 Nov 2015
Milestone Removed:
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment