? ? ? Success

User tests: Successful: Unsuccessful:

avatar sanderpotjer
sanderpotjer
16 Aug 2015

This Pull Requests adds a new Menu Item Type "Logout" to the available menu item types. It allows users to create a menu item "Logout" that directly logouts a user when clicking on the menu item. Optionally you can set a page to redirect after logout, otherwise the user will be redirected to the default (home) page.

In this way it is no longer needed to use the "Login" menu-item type to logout, which shows a page with a "Logout" button only.

For the JFIELD_LOGOUT_REDIRECT_PAGE_DESC and JFIELD_LOGOUT_REDIRECT_PAGE_LABEL the same description is used as for the mod_login with the similar functionality (MOD_LOGIN_FIELD_LOGOUT_REDIRECTURL_DESC and MOD_LOGIN_FIELD_LOGOUT_REDIRECTURL_LABEL).

Test instructions

After applying the patch you can create a new menu-item from type "Logout"
screen shot 2015-08-16 at 20 24 48

Provide a title and typically you would set the Access to "Registered" so only logged-in users can see the logout menu-item.

Optionally you can select a "Logout Redirection Page" under "Options" that will be used to redirect the user to after logout. "Default" will return to the default (home) page.
screen shot 2015-08-16 at 20 29 18

Save the menu item and login with a user on the frontend of the website. The logout menu item should be visible. Clicking on the logout menu item should end your user session and redirect to the page set.

Votes

# of Users Experiencing Issue
1/2
Average Importance Score
5.00

avatar sanderpotjer sanderpotjer - open - 16 Aug 2015
avatar sanderpotjer sanderpotjer - change - 16 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 17 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 17 Aug 2015
Easy No Yes
avatar zero-24 zero-24 - change - 17 Aug 2015
Category Front End
avatar sanderpotjer
sanderpotjer - comment - 17 Aug 2015

Default logout page set to the homepage instead of current page. Usage of current page is not possible as that would be the logout page (results in loop). Default page makes more sense as well to prevent 404 errors on logout when logging out while being on a page that is only visible for registered users.

avatar RickR2H RickR2H - test_item - 17 Aug 2015 - Tested successfully
avatar RickR2H
RickR2H - comment - 17 Aug 2015

Nice patch Sander! Works as expected!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar justinherrin
justinherrin - comment - 17 Aug 2015

Excellent new feature! No more having to use a 3pd extension to accomplish this task.

Tested and found to work great.

avatar justinherrin justinherrin - test_item - 17 Aug 2015 - Tested successfully
avatar peterlose peterlose - test_item - 17 Aug 2015 - Tested successfully
avatar peterlose
peterlose - comment - 17 Aug 2015

Tested. All good!

avatar RichardR2H RichardR2H - test_item - 17 Aug 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 17 Aug 2015

@brianteeman Can we get your language review? If you are ok with it we can set it RTC ;) Thanks for all the testers and @sanderpotjer :smile:

avatar waader
waader - comment - 17 Aug 2015

Quote: "Provide a title and typically you would set the Access to "Registered" so only logged-in users can see the logout menu-item."

The other way around: Is there a way to hide a login menu-item for registered users, when the have logged in?

When using a login menu-item and a logout menu-item both menu-items are visible after a successful login. Ideally only the logout menu-item should be visible.

avatar brianteeman
brianteeman - comment - 17 Aug 2015

@waader yes you can hide login items for users who are logged in. See
https://brian.teeman.net/joomla/415-the-guest-user-group-hiding-menu-items-and-modules

On 17 August 2015 at 19:33, waader notifications@github.com wrote:

Quote: "Provide a title and typically you would set the Access to
"Registered" so only logged-in users can see the logout menu-item."

The other way around: Is there a way to hide a login menu-item for
registered users, when the have logged in?

When using a login menu-item and a logout menu-item both menu-items are
visible after a successful login. Ideally only the logout menu-item should
be visible.


Reply to this email directly or view it on GitHub
#7703 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar MAT978
MAT978 - comment - 17 Aug 2015

one more successful test - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar MAT978 MAT978 - test_item - 17 Aug 2015 - Tested successfully
avatar waader
waader - comment - 17 Aug 2015

@brianteeman Thanks for the hint!

avatar waader waader - test_item - 17 Aug 2015 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 17 Aug 2015

Thanks all for your feedback & testing!

avatar ZacharyDraper ZacharyDraper - test_item - 19 Aug 2015 - Tested successfully
avatar mehmetalipamukci
mehmetalipamukci - comment - 20 Aug 2015

All good.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar mehmetalipamukci mehmetalipamukci - test_item - 20 Aug 2015 - Tested successfully
avatar mehmetalipamukci mehmetalipamukci - test_item - 20 Aug 2015 - Tested successfully
avatar timhaeuser timhaeuser - test_item - 20 Aug 2015 - Tested successfully
avatar timhaeuser timhaeuser - test_item - 20 Aug 2015 - Tested successfully
avatar Blutengel89 Blutengel89 - test_item - 20 Aug 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 20 Aug 2015

@brianteeman can we RTC or do we need language changes?

avatar kathastaden kathastaden - test_item - 20 Aug 2015 - Tested successfully
avatar kathastaden
kathastaden - comment - 20 Aug 2015

Everything worked well!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar Teck95
Teck95 - comment - 20 Aug 2015

@test The logout-option is very easy and fast to be set up. Successful test and nice patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar Teck95 Teck95 - test_item - 20 Aug 2015 - Tested successfully
avatar hitchblade
hitchblade - comment - 20 Aug 2015

Create a new Menu-Item -> Users -> Logout and let the Default-Option. Logged in as Administrator and it Works. Very cool and easy to use.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar hitchblade hitchblade - test_item - 20 Aug 2015 - Tested successfully
avatar roland-d roland-d - change - 21 Aug 2015
Status Pending Ready to Commit
avatar watchfulli-dev
watchfulli-dev - comment - 21 Aug 2015

@test success, after applying the patch I can see a new "Logout" option for com_users, creating a menu item as described and clicking on it after I've logged in, the logout went fine.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar watchfulli-dev watchfulli-dev - test_item - 21 Aug 2015 - Tested successfully
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2015
Labels Added: ?
avatar bullet64
bullet64 - comment - 29 Aug 2015

I have missed this so many times. Thanks!

Works as expected.

avatar SiteOp SiteOp - test_item - 10 Sep 2015 - Tested successfully
avatar SiteOp
SiteOp - comment - 10 Sep 2015

Perfect.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar dam-man dam-man - test_item - 10 Oct 2015 - Tested successfully
avatar dam-man
dam-man - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on 1d8e29c

Nobody clicked the "Tested Succesfully" button so it won't be completed.
Nice option Sander :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar willoweb
willoweb - comment - 10 Oct 2015

Worked as expected
Thanks Sander


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar crommie crommie - test_item - 10 Oct 2015 - Tested successfully
avatar crommie
crommie - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on 1d8e29c

Works.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7703.

avatar roland-d
roland-d - comment - 17 Oct 2015

Thanks @sanderpotjer merged into 3.5-dev with commit 489fb6

avatar roland-d roland-d - change - 17 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-17 08:30:59
Closed_By roland-d
avatar sanderpotjer
sanderpotjer - comment - 17 Oct 2015

Thanks @roland-d and all testers!

avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment