I have tested this item successfully on 1575f4a

I have tested this item successfully on 1575f4a

Tested successfully!
Joomla 3.4.5

RTC. Thanks

sorry, but to early for RTC
here is still need to fix incorect usage of $renderLayout property, it cannot be used for getInput() because it used in JField::renderField()
so it make conflict

Back to pending.

@Fedik any suggestion here?

@dgt41 I think can use another property, eg
@protected $layout = 'joomla.form.field.moduleposition';
and then:
return JLayoutHelper::render($this->layout, $displayData);

@zero-24 does this need more tests? that change was straight forward

RTC than. Thanks.

Great work @dgt41 :)

After checking PRs I have only 2 recommendations:

• If you see all your PRs you end with the same getInput() function code. I think we have to move that directly to JFormField and it doesn't break B/C. It will save lines of code.
• Addittionally the getLayoutData() can be pre-filled directly from JFormField so that fields only take care of returning their required custom data. Things like id, name, etc. are in all the fields. So if child fields need additional data they will call $layoutData = parent::getLayoutData() and then add anything they need.
• Also for reusability and to allow that extension devs can use different layouts for the same field we need to enable support to change the active layout from field XML attributes. Adding support for something like layout="mylib.form.field.myfield". It only requires to add 1 line of code.
• Creating a getRenderer() function that would allow that any extension can use their own renderer without having to override the getInput() method.

I think I have already commented this so maybe is that it's not going to happen in v3.5 but I think is the best moment to add all this features. If this is done somewhere else please tell me so I can review it.

I've seen this method has been included recently:

https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/field.php#L931

In my opinion the layout data that the label and the input need are the same. I actually faced some situations where I had to render the label inside the input itself.

Do you think is better that I send a PR to try to change things in JFormField and we use it as base for the rest?

@phproberto If I do the getInput and the render suggestions I get a nasty error in the menu item edit page:

Probably I need more coffee...

This PR has received new commits.

CC: @rmittl, @svom

@dgt41 On testing i get: Fatal error: Call to undefined method JFormFieldModulePosition::getRenderer() in JRoot/libraries/cms/form/field/moduleposition.php on line 146

@zero-24 all these PRs require also #8248

I have tested this item successfully on 22f835a

Ok than. I don't look great in hathor but it works. Thanks

This PR has received new commits.

CC: @rmittl, @svom, @zero-24

I have tested this item unsuccessfully on fc41841

Module Edit page is broken in Hathor - sorry x

Can we get rid of this whitespace?

This PR has received new commits.

CC: @designbengel, @rmittl, @svom, @zero-24

Fixed that:

I am gonna close this one for now as it only affects hathor, lets not spend too much energy on this

I was going to say that