See other PR

@nikosdion
?
We have to solves this. This is a bug imho.

No, Jean-Marie, this does NOT happen with either Joomla! 3.4.3 or the staging branch of the CMS. This bug is something you caused with your other PR and I agree that it has to be fixed. My recommendation to fix the issue #7695 is to NOT apply #7694

Please close this issue.

@nikosdion
As far as I can test, this bug is unrelated to the other PR as it happens without it. I suggest you test.
(BTW: I have proposed another solution for the other PR).

As I implied above, I am currently looking at FIVE different sites, four running Joomla! 3.4.3 and one on the staging branch and none of them displays the behaviour you mentioned. Is it possible that you are using a third party User Profile fields plugin which cocks up the Javascript or HTML on the page? Because that would explain what you're seeing.

Try installing a blank Joomla! 3.4.3 site and test it.

I did not have any 3rd party extension.

Installed a brand new staging/master.
Enabled both plugins:
Profile plugin and 2factor authentication plugin
edit user

I do confirm the issue.
See this movie:
https://www.dropbox.com/s/k1nfism4u0bwhkf/2factor.mp4?dl=0

I do confirm I do not get the issue on a 3.4.3 site.

I don't know what you are doing wrong but there really is no such issue.

Two more tests.

1. New Joomla! 3.4.1 site and upgraded it to 3.4.3. Cannot reproduce. So it's not an upgrade issue.

2. Brand new Joomla! 3.4.3 site installation. Cannot reproduce. So it's not an issue in 3.4.3.

I am following your instructions to only enable the user profiles and the two factor authentication plugins. No other change made to the default installation.

What you describe would only make sense if the tooltip class produced invalid HTML. This would mean that the very next thing after the user profile fields –the Authentication Method drop-down of the Two Factor Authentication tab– would be screwed up. That could lead to what you are seeing but as I'm tired of saying this DOES NOT happen out of the box.

Could it be a browser extension you are using? Or something that has to do with the ancient OS X version you're still using? I'm trying with Firefox, Chrome and Safari on Mac OS X Yosemite and really, seriously can't reproduce this.

I've spent more than two hours on this. It's a Sunday morning and I'm supposed to be on vacation. Sorry, I can't waste any more time chasing windmills.

As I said, this happens on staging, NOT on 3.4.3.
Will test on Yosemite.

Same on Yosemite.

I can confirm this behavior on latest master installation

Ah... thanks. I thought I was getting totally insane...

Two Factor Authentication has Tab:

but in some reason does not have a "tab content" section:

Something went wrong with the user form rendering, in backend.

ah, it inside "#profile"

so, seems just broken the form markup

I think I found why it was working before:
We had 2 </div> in the dob.php field which was causing other issues. This was rightfully solved

in /layouts/plugins/user/profile/fields/dob.php
If I add a </div> line 18, then this issue is solved (but we get back the original dob issue).

seems bug was introduced somewhere here #4103 and then #7340 ?

Yep, these were solving the dob issue, but was not tested in the present case where 2factorauth was on.

@Bakual
Could you look into this?

this seems fix the problem:

// Closing the opening .control-group and .control-label div so we can add our info text on own line ?>
</div></div><div class="controls"><?php echo $text; ?></div>

means we close 2 previous div, add "text" and then open these 2 div again..

but I not very understand how to test it with #7340

I tested this:
adding </div> line 21 of /layouts/plugins/user/profile/fields/dob.php (end of file), i.e. the dob is no more displayed in all tabs in frontend and works OK for here.

current code is:

</div><div class="controls"><?php echo $text; ?></div>
<div class="control-group"><div class="control-label">

it close 1 div (line 18) and then open 2 div (line 20)
but before open 2 div we should close equivalent amount of div:

</div></div> <!-- close 2 div-->
<div class="controls"><?php echo $text; ?></div>
<div class="control-group"><div class="control-label">  <!-- open 2 div-->

Can you make a PR?

@infograf768 there it is #7698