? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
15 Aug 2015

As title says.
To test, enable one (or both) of the Two Factor Authentification plugins, then edit a user (backend) or login and edit the user profile (frontend).

Tooltip should look as before patch, i.e.
screen shot 2015-08-15 at 08 32 39

Thanks @nikosdion for testing

avatar infograf768 infograf768 - open - 15 Aug 2015
avatar infograf768 infograf768 - change - 15 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2015
Labels Added: ?
avatar infograf768 infograf768 - change - 15 Aug 2015
Title
CS: normalising Authentification Method field tooltip
CS: normalising Authentication Method field tooltip
avatar infograf768 infograf768 - change - 15 Aug 2015
Category Code style
avatar infograf768 infograf768 - change - 15 Aug 2015
Easy No Yes
avatar infograf768 infograf768 - change - 15 Aug 2015
Title
CS: normalising Authentication Method field tooltip
CS: normalising Authentification Method field tooltip
avatar nikosdion
nikosdion - comment - 15 Aug 2015

My advice is to not touch it. Ttip text requires javascriot you are not
including as far as I can see. This will cause bc breaks in front-end. Not
on computer, reading code on phone. Please Don't touch it.

avatar infograf768
infograf768 - comment - 16 Aug 2015

Maybe we just have to add JHtml::_('bootstrap.tooltip'); ?

My eclipse (Keppler) is real unhappy about each of these files and mark them with a red cross.

avatar infograf768
infograf768 - comment - 16 Aug 2015

or, my eclipse would be satisfied with:
title="<?php echo '<strong>' . JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL') . '</strong><br />' . JText::_('COM_USERS_USER_FIELD_TWOFACTOR_DESC'); ?>">
instead of the existing
title="<strong><?php echo JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL') ?></strong><br /><?php echo JText::_('COM_USERS_USER_FIELD_TWOFACTOR_DESC') ?>">

avatar Fedik
Fedik - comment - 16 Aug 2015

test ok on 50% here :wink:
in backend all good, but on the site I got:
screen 2015-08-16 19 03 20 478x116

not very understand why, because strings looks the same :smile:

and small wish, can you please use JHtml::_('tooltipText', 'string1', 'string2'); instead of JHtml::tooltipText( 'string1', 'string2'); ...
so people who override core JHtml::tooltipText method, can be sure that it work as expected everywhere

avatar infograf768
infograf768 - comment - 16 Aug 2015

This is why I proposed the second solution:
title="<?php echo '<strong>' . JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL') . '</strong><br />' . JText::_('COM_USERS_USER_FIELD_TWOFACTOR_DESC'); ?>">
so that we do not mess with js.

BTW: my screenshot above was in frontend.

avatar Fedik
Fedik - comment - 16 Aug 2015

not sure, I tried couple times, but string still untranslated, very strange...

JHtml::_('bootstrap.tooltip') already loaded in the label layout layouts/joomla/form/renderlabel.php, when Joomla render other fields ...
and I see no problem with use JHtml here, as the label already has class class="hasTooltip", so tooltip script applies for this label, even without this patch

avatar infograf768
infograf768 - comment - 17 Aug 2015

the strings were wrong for frontend in this patch ;)
I am correcting this now and follow @nikosdion advice to not use JHtml::tooltipText

I change the PR to use the alternative code to, at least, make Eclipse happy.

avatar infograf768
infograf768 - comment - 17 Aug 2015

Please test again :smiley:

avatar Fedik
Fedik - comment - 17 Aug 2015

test works good :wink:

avatar Fedik Fedik - test_item - 17 Aug 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Aug 2015

@zero-24
Can you test and RTC as it is a very simple change?

avatar zero-24 zero-24 - test_item - 17 Aug 2015 - Tested successfully
avatar zero-24 zero-24 - change - 17 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 17 Aug 2015

Works & Nothing is broken. --> RTC Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7694.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 21 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-21 13:50:09
Closed_By rdeutz
avatar rdeutz rdeutz - close - 21 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - close - 21 Aug 2015
avatar rdeutz rdeutz - reference | 2e32773 - 21 Aug 15
avatar rdeutz rdeutz - merge - 21 Aug 2015
avatar rdeutz rdeutz - close - 21 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 21 Aug 2015
Milestone Added:
avatar infograf768 infograf768 - head_ref_deleted - 23 Aug 2015

Add a Comment

Login with GitHub to post a comment