User tests: Successful: Unsuccessful:
Hello,
I have found email validation issue in joomla 3.3.6, joomla 3.4.2 and joomla 3.4.3 versions.
I have fixed this issue and create PR of it, please review it.
I have changed validate.js file for email validation.
Right now, joomla consider "test@test" as a valid email address and I think this is not valid email address.
Testing Information:
Current Output:
Actual Output:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | JavaScript |
@brianteeman I think you meant intranet?
autocorrect - yes
On 6 August 2015 at 13:56, Thomas Hunziker notifications@github.com wrote:
@brianteeman https://github.com/brianteeman I think you meant intranet?
—
Reply to this email directly or view it on GitHub
#7644 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Thank you for your contribution, @RonakParmar!
Sorry, this is wrong. You mean a fully qualified domain name (https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names) but as @brianteeman said, an unqualified hostname (as root@localhost) is also valid depending on the system.
Closed.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-06 13:01:46 |
Closed_By | ⇒ | Kubik-Rubik |
I was not aware about this, thanks for update me.
Should I close this PR, or wait for others to comment?
Okay, Just refresh the page and see your comment.
Thanks for closing.
It can be a valid address on an internet
On 6 August 2015 at 13:30, RonakParmar notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/