? Success

User tests: Successful: Unsuccessful:

avatar RonakParmar
RonakParmar
6 Aug 2015

Hello,
I have found email validation issue in joomla 3.3.6, joomla 3.4.2 and joomla 3.4.3 versions.
I have fixed this issue and create PR of it, please review it.
I have changed validate.js file for email validation.
Right now, joomla consider "test@test" as a valid email address and I think this is not valid email address.

Testing Information:

  • Log-in into site
  • Goto Edit user profile page
  • Enter wrong email address for example "test@test".
  • Press submit button, user data will save.

Current Output:

  • Email address is not valid still data will save.

Actual Output:

  • Error message like Invalid email address.
avatar RonakParmar RonakParmar - open - 6 Aug 2015
avatar RonakParmar RonakParmar - change - 6 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2015
Labels Added: ?
avatar gunjanpatel gunjanpatel - change - 6 Aug 2015
Category JavaScript
avatar RonakParmar RonakParmar - change - 6 Aug 2015
The description was changed
avatar RonakParmar RonakParmar - change - 6 Aug 2015
The description was changed
avatar brianteeman
brianteeman - comment - 6 Aug 2015

It can be a valid address on an internet

On 6 August 2015 at 13:30, RonakParmar notifications@github.com wrote:

Hello,
I have found email validation issue in joomla 3.3.6, joomla 3.4.2 and
joomla 3.4.3 versions.
I have fixed this issue and create PR of it, please review it.
I have changed validate.js file for email validation.
Right now, joomla consider "test@test" as a valid email address and I

think this is not valid email address.

You can view, comment on, or merge this pull request online at:

#7644
Commit Summary

  • Fixed email validation issue

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#7644.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Bakual
Bakual - comment - 6 Aug 2015

@brianteeman I think you meant intranet?

avatar brianteeman
brianteeman - comment - 6 Aug 2015

autocorrect - yes

On 6 August 2015 at 13:56, Thomas Hunziker notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I think you meant intranet?


Reply to this email directly or view it on GitHub
#7644 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Kubik-Rubik
Kubik-Rubik - comment - 6 Aug 2015

Thank you for your contribution, @RonakParmar!

Sorry, this is wrong. You mean a fully qualified domain name (https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names) but as @brianteeman said, an unqualified hostname (as root@localhost) is also valid depending on the system.

Closed.

avatar Kubik-Rubik Kubik-Rubik - change - 6 Aug 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-08-06 13:01:46
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 6 Aug 2015
avatar Kubik-Rubik Kubik-Rubik - close - 6 Aug 2015
avatar RonakParmar
RonakParmar - comment - 6 Aug 2015

I was not aware about this, thanks for update me.
Should I close this PR, or wait for others to comment?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7644.

avatar RonakParmar
RonakParmar - comment - 6 Aug 2015

Okay, Just refresh the page and see your comment.
Thanks for closing.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7644.

Add a Comment

Login with GitHub to post a comment