? Success
Pull Request for # 7587

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
5 Aug 2015

See #7587 for instructions.

After patch I get the subs OK:
screen shot 2015-08-05 at 10 47 23

I have added the new css:

.nav-collapse.in.collapse {
    overflow: visible;
    height: 0;
  }

in /media/jui/less/responsive-navbar.less and ran generatecss.php

If judged necessary we could limit it to protostar only.

avatar infograf768 infograf768 - open - 5 Aug 2015
avatar infograf768 infograf768 - change - 5 Aug 2015
The description was changed
avatar brianteeman
brianteeman - comment - 5 Aug 2015

Almost but not quite. See screenshot

screen shot 2015-08-05 at 04 21 04


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7629.

avatar brianteeman brianteeman - change - 5 Aug 2015
Rel_Number 7587
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 5 Aug 2015
Category Templates (site)
avatar infograf768
infograf768 - comment - 5 Aug 2015

I do not get this here (Firefox)
screen shot 2015-08-05 at 11 38 27

avatar brianteeman
brianteeman - comment - 5 Aug 2015

My screenshot was with chrome

On 5 August 2015 at 10:40, infograf768 notifications@github.com wrote:

I do not get this here (Firefox)
[image: screen shot 2015-08-05 at 11 38 27]
https://cloud.githubusercontent.com/assets/869724/9082799/9d41de00-3b66-11e5-8ae2-b092d98d3d2f.png


Reply to this email directly or view it on GitHub
#7629 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 5 Aug 2015

I confirm on chrome and safari with very long menu aliases. IMHO not a bid deal but this is a different issue than the one solved here. Not sure how to solve.

avatar MixingOnBeat
MixingOnBeat - comment - 5 Aug 2015

Awesome guys! The fix given here fa38882 to these files fixes the issue on my site. If you wish to test or verify: www.djexplosionsd.com

I don't know if I should start a new tracker, but is there also a way to fix the time on how long a parent menu with child menus can be pressed on a phone before it becomes active?

For example, press the "MUSIC" menu on my site with an Android phone, and you'll see a child menu under it. But it opens briefly not allowing you to select anything else since the parent menu also takes you to a page. Hopefully you understand what I mean.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7629.

avatar MixingOnBeat MixingOnBeat - test_item - 5 Aug 2015 - Tested successfully
avatar Bakual
Bakual - comment - 5 Aug 2015

If judged necessary we could limit it to protostar only.

Yes, please do it only in Protostar (and maybe ISIS).
The /media/jui/less/responsive-navbar.less files is coming from Bootstrap and the only changes we made to it are to cope with the MooTools modals.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2015
The description was changed
Labels Added: ?
avatar infograf768
infograf768 - comment - 5 Aug 2015

@bakual
changed to protostar only as we don't need it for Isis.

avatar infograf768
infograf768 - comment - 5 Aug 2015

@brianteeman

Can you test by first patching with this PR, then adding the z-index in protostar template.css, line 7410:

@media (max-width: 979px) {
    .nav-collapse.in.collapse {
        overflow: visible;
        height: 0;
        z-index: 100;
    }
}
avatar Bakual
Bakual - comment - 5 Aug 2015

Current PR fixes the issue for Protostar. Thanks!

avatar Bakual Bakual - test_item - 5 Aug 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Aug 2015

@infograf768 yes that z-index works in chrome


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7629.

avatar infograf768 infograf768 - change - 5 Aug 2015
Status New Ready to Commit
avatar infograf768
infograf768 - comment - 5 Aug 2015

RTC. Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7629.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2015
Labels Added: ?
avatar rdeutz rdeutz - close - 5 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - close - 5 Aug 2015
avatar rdeutz rdeutz - reference | eaf5b61 - 5 Aug 15
avatar rdeutz rdeutz - merge - 5 Aug 2015
avatar rdeutz rdeutz - close - 5 Aug 2015
avatar rdeutz rdeutz - change - 5 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-05 16:44:42
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 5 Aug 2015
Milestone Added:
avatar infograf768 infograf768 - head_ref_deleted - 6 Aug 2015

Add a Comment

Login with GitHub to post a comment