Feeling Lucky
?
[#7628] - Tag edit form cleanup
- Closed
- 6 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7628
- Diff
- Bakual:TagURL
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
The tag edit view currently shows the "images" tab twice.
This PR
While trying to fix the doubled tab, I suprisingly stumbled over a few other funny things in that form. So I fixed those as well. This PR now
- Removes the doubled "images" tab, leaving it to the JLayout to render it.
- Removes a workaround for the "urls" columng in the #__tags table. The underlying issue has been fixed with #6314. The column isn't used anywhere and could most likely be removed from the database. I just leave it there for B/C reasons.
- Removes a
JHtml::addIncludePath()call since the added path doesn't even exist. - Removes
$params"shortcut". We're not using params anywhere in the layout.
Testing
Make sure you can create and edit tags.
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Tags |
| Status | New | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
zero-24
- comment
- 6 Aug 2015
Tested successful. What was changed that produces this issue? I have just see a component that has similiar issues on staging but no issues on 3.4.3 which is a B/C break ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7628.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-06 07:04:02 |
| Closed_By | ⇒ | Bakual |
| Labels |
Removed:
?
|
||
@test
PR works as intended. Able to create and edit tags.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7628.