Looks fine, allthough I will miss that funny helper class

Thanks for the tip about that helper class @Bakual

I got the following errors when applying the patch:

Warning: require_once(C:\MAMP\htdocs\joomla-cms\administrator/components/com_tags/helpers/tags.php): failed to open stream: No such file or directory in C:\MAMP\htdocs\joomla-cms\administrator\components\com_tags\controller.php on line 31

Fatal error: require_once(): Failed opening required 'C:\MAMP\htdocs\joomla-cms\administrator/components/com_tags/helpers/tags.php' (include_path='.;C:\php\pear') in C:\MAMP\htdocs\joomla-cms\administrator\components\com_tags\controller.php on line 31

thanks @n9iels should be fixed now ;)

Nearly fixed, do the same for the views/tag/view.html.php. Now you get the same error over there

@zero-24 Tobias better make a search for all the places this helper might exist ???? Too hard to die…

Yes I can do this tomorrow.

Ouch. The line to remove is https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_tags/views/tag/view.html.php#L78

That line doesn't make any sense at all. TagsHelper isn't used anywhere there.

I haven't found any other occurance of it. Hopefully it really is the last one.

Fixed: zero-24@409218f

BTW: Why tags always load the language file? Any reason for this?
https://github.com/zero-24/joomla-cms/blob/remoaveTagsSidebar/administrator/components/com_tags/views/tag/view.html.php#L71-L74

I doubt that makes sense. The language will already be loaded by the system anyway. I never had to load the component language file manually for my extension.

A fair majority of the tags code was copied from com_categories, to include all of its extra quirks.

@zero-24 Can you fix the merge conflicts?

done @roland-d

Thanks everybody, merged.