? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
3 Aug 2015

What is changed?

This PR removes the useless Sidebar for Tags and fixes some mirror CS

Bevor the change

bevor_tags_removal

After the change

after_tags_removal

How to test

  • install 3.5
  • access com tags
  • see Bevor the change
  • apply the patch
  • access com tags
  • see After the change

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
1.00

avatar zero-24 zero-24 - open - 3 Aug 2015
avatar zero-24 zero-24 - change - 3 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 Aug 2015
Title
[3.5] [Imp] Remove unless tags sidebar
[3.5] [Imp] Remove useless tags sidebar
avatar zero-24 zero-24 - change - 3 Aug 2015
The description was changed
avatar Bakual
Bakual - comment - 3 Aug 2015

Looks fine, allthough I will miss that funny helper class :laughing:

avatar zero-24
zero-24 - comment - 3 Aug 2015

Thanks for the tip about that helper class @Bakual

avatar zero-24 zero-24 - change - 3 Aug 2015
Easy No Yes
avatar zero-24 zero-24 - change - 3 Aug 2015
Category Administration UI/UX
avatar lexakiker lexakiker - test_item - 3 Aug 2015 - Not tested
avatar lexakiker lexakiker - test_item - 3 Aug 2015 - Not tested
avatar lexakiker lexakiker - test_item - 3 Aug 2015 - Not tested
avatar lexakiker lexakiker - test_item - 3 Aug 2015 - Not tested
avatar lexakiker lexakiker - test_item - 3 Aug 2015 - Not tested
avatar lexakiker lexakiker - test_item - 3 Aug 2015 - Not tested
avatar n9iels
n9iels - comment - 4 Aug 2015

I got the following errors when applying the patch:

Warning: require_once(C:\MAMP\htdocs\joomla-cms\administrator/components/com_tags/helpers/tags.php): failed to open stream: No such file or directory in C:\MAMP\htdocs\joomla-cms\administrator\components\com_tags\controller.php on line 31

Fatal error: require_once(): Failed opening required 'C:\MAMP\htdocs\joomla-cms\administrator/components/com_tags/helpers/tags.php' (include_path='.;C:\php\pear') in C:\MAMP\htdocs\joomla-cms\administrator\components\com_tags\controller.php on line 31
avatar zero-24
zero-24 - comment - 4 Aug 2015

thanks @n9iels :smile: should be fixed now ;)

avatar n9iels
n9iels - comment - 4 Aug 2015

Nearly fixed, do the same for the views/tag/view.html.php. Now you get the same error over there

avatar dgt41
dgt41 - comment - 4 Aug 2015

@zero-24 Tobias better make a search for all the places this helper might exist ???? Too hard to dieā€¦

avatar zero-24
zero-24 - comment - 4 Aug 2015

Yes I can do this tomorrow.

avatar Bakual
Bakual - comment - 5 Aug 2015

Ouch. The line to remove is https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_tags/views/tag/view.html.php#L78

That line doesn't make any sense at all. TagsHelper isn't used anywhere there.

I haven't found any other occurance of it. Hopefully it really is the last one.

avatar zero-24
zero-24 - comment - 5 Aug 2015
avatar Bakual
Bakual - comment - 5 Aug 2015

I doubt that makes sense. The language will already be loaded by the system anyway. I never had to load the component language file manually for my extension.

avatar mbabker
mbabker - comment - 5 Aug 2015

A fair majority of the tags code was copied from com_categories, to include all of its extra quirks.

avatar Kubik-Rubik Kubik-Rubik - change - 7 Aug 2015
Milestone Added:
avatar roland-d
roland-d - comment - 17 Oct 2015

@zero-24 Can you fix the merge conflicts?

avatar zero-24
zero-24 - comment - 17 Oct 2015

done @roland-d

avatar roland-d roland-d - change - 17 Oct 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-10-17 11:38:05
Closed_By roland-d
avatar roland-d roland-d - close - 17 Oct 2015
avatar roland-d roland-d - reference | a97c9dc - 17 Oct 15
avatar roland-d roland-d - merge - 17 Oct 2015
avatar roland-d roland-d - close - 17 Oct 2015
avatar roland-d
roland-d - comment - 17 Oct 2015

Thanks everybody, merged.

avatar zero-24 zero-24 - head_ref_deleted - 17 Oct 2015

Add a Comment

Login with GitHub to post a comment