? ? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
3 Aug 2015

This backports the user.css that we have in protostar back to beez3. For the backed we can use a custom.css file.

How to test

  • set beez3 as default template
  • access the frontend
  • see all is good.
  • apply the patch
  • add a user.css with custom styling to this folder /templates/bezz3/css/user.css
  • reload the page
  • see that the file gets loaded.

Other changes

Make the checks consistent and use if (file_exists($file) && filesize($file) > 0) and $doc->addStyleSheetVersion($file);

avatar zero-24 zero-24 - open - 3 Aug 2015
avatar zero-24 zero-24 - change - 3 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 Aug 2015
Milestone Added:
avatar brianteeman
brianteeman - comment - 3 Aug 2015

The title says Beez but there are changes in all 4 templates?

avatar zero-24
zero-24 - comment - 3 Aug 2015

yes as the "new feature" is only in beez and the others are just changed to be consistend. But to avoid confusing i will fix the title

avatar zero-24 zero-24 - change - 3 Aug 2015
Title
[3.5] [imp] Add the ability to use a custom CSS file with beez3 see #4211
[3.5] [imp] Add the ability to use a custom CSS file with beez3 & make the other similiar checks consistend see #4211
avatar zero-24 zero-24 - change - 3 Aug 2015
Easy No Yes
avatar zero-24 zero-24 - change - 3 Aug 2015
Category Templates (admin) Templates (site)
avatar SiteOp
SiteOp - comment - 12 Sep 2015

Test Beez/Protostar. It works.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar SiteOp SiteOp - test_item - 12 Sep 2015 - Tested successfully
avatar crommie crommie - test_item - 10 Oct 2015 - Tested successfully
avatar crommie
crommie - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar crommie crommie - test_item - 10 Oct 2015 - Tested successfully
avatar crommie
crommie - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar crommie crommie - test_item - 10 Oct 2015 - Tested successfully
avatar crommie
crommie - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar crommie crommie - test_item - 10 Oct 2015 - Tested successfully
avatar crommie
crommie - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar snarf007 snarf007 - test_item - 10 Oct 2015 - Not tested
avatar snarf007
snarf007 - comment - 10 Oct 2015

I have not tested this item.

Applied patch and created the user.css file via the template manager.
Added the following code in the css file:
body {
background: pink;
}

Result a pink backgound in the frontend.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar snarf007 snarf007 - test_item - 10 Oct 2015 - Tested successfully
avatar snarf007
snarf007 - comment - 10 Oct 2015

I have tested this item :white_check_mark: successfully on bb1f130

Applied patch and created the user.css file via the template manager.
Added the following code in the css file:
body {
background: pink;
}

Result a pink backgound in the frontend.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar zero-24 zero-24 - change - 10 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 10 Oct 2015

RTC. Thanks for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2015
Labels Added: ?
avatar roland-d roland-d - change - 24 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-24 11:57:51
Closed_By roland-d
avatar roland-d roland-d - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar roland-d roland-d - reference | 1268751 - 24 Oct 15
avatar roland-d roland-d - merge - 24 Oct 2015
avatar roland-d roland-d - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar roland-d
roland-d - comment - 24 Oct 2015

Thanks all, change has been merged.

avatar zero-24 zero-24 - head_ref_deleted - 24 Oct 2015
avatar zero-24
zero-24 - comment - 24 Oct 2015

Thanks

Add a Comment

Login with GitHub to post a comment