? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Aug 2015

This PR removes the inline javascript from the ISIS and Hathor templates which adds focus to the username field on the admin login screen and just uses autofocus=true instead

avatar brianteeman brianteeman - open - 1 Aug 2015
avatar brianteeman brianteeman - change - 1 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Aug 2015
Category Administration JavaScript Templates (admin)
avatar brianteeman brianteeman - change - 1 Aug 2015
The description was changed
avatar justinherrin
justinherrin - comment - 1 Aug 2015

I believe you can just add the word autofocus to the input tags. No need for autofocus="true" according to w3schools. I had to add autofocus="true" in #7604 because it was being added to an XML file and not the input tag directly.

One thought about doing this HTML5 attribute is the fact that it is not supported in all browsers, specifically anything lower than IE10. Does that matter?

avatar mbabker
mbabker - comment - 1 Aug 2015

Our templates have a polyfill for backporting stuff. So as long as it's covered then no big deal. And if the browser ignores it completely and the page still works, I'd say no big deal either.

avatar Fedik Fedik - test_item - 1 Aug 2015 - Tested successfully
avatar Fedik
Fedik - comment - 1 Aug 2015

works good :+1:

avatar dgt41
dgt41 - comment - 1 Aug 2015

works for me as well

avatar jwaisner
jwaisner - comment - 2 Aug 2015

@test

PR works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7607.

avatar jwaisner jwaisner - test_item - 2 Aug 2015 - Tested successfully
avatar brianteeman brianteeman - change - 2 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 2 Aug 2015

RTC

avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2015
Labels Added: ?
avatar Bakual Bakual - reference | 9b10f2e - 2 Aug 15
avatar Bakual Bakual - merge - 2 Aug 2015
avatar Bakual Bakual - close - 2 Aug 2015
avatar Bakual Bakual - change - 2 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-02 14:37:28
Closed_By Bakual
avatar Bakual Bakual - close - 2 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - close - 2 Aug 2015
avatar Bakual Bakual - change - 2 Aug 2015
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2015
Labels Removed: ?
avatar brianteeman brianteeman - head_ref_deleted - 4 Aug 2015

Add a Comment

Login with GitHub to post a comment