Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7553] - Fix line ending issues when running tests in windows

? ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
26 Jul 2015

In JHtmlSelect::radioSelect() we are using \n to represent a new line. However in our unit tests we are actually creating a new line (i.e. using PHP_EOL). This gives errors on a windows system. So I have explicitly new line instances with \n

With this fix I now have all unit tests passing on Windows 8.1

avatar wilsonge wilsonge - open - 26 Jul 2015
avatar wilsonge wilsonge - change - 26 Jul 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 26 Jul 2015
The description was changed
Labels Added: ?
avatar mbabker mbabker - reference | 71b37dc - 26 Jul 15
avatar mbabker mbabker - merge - 26 Jul 2015
avatar mbabker mbabker - close - 26 Jul 2015
avatar mbabker mbabker - change - 26 Jul 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-07-26 18:47:48
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 26 Jul 2015
avatar wilsonge wilsonge - head_ref_deleted - 26 Jul 2015
avatar zero-24 zero-24 - change - 27 Jul 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment