Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7552] - Convert IDNA_Convert library to be Composer managed, update to 0.9

? ? ? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
26 Jul 2015

This PR moves the IDNA_Convert library from a Joomla library extension to being managed via Composer (using https://github.com/phpWhois/idna-convert as the source). It also runs an update to version 0.9 of the library and restores the accidentally deleted test class for our Punycode conversions (only affects the 3.5 branch).

Testing

With the patch applied, things should still work as intended. If you've got strings going through the Punycode library (I'm sure JM can tell us all where this is checked), those should still be processed correctly.

avatar mbabker mbabker - open - 26 Jul 2015
avatar mbabker mbabker - change - 26 Jul 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 27 Jul 2015

e-mail fields and urls fields.
Basically for example:
Entering in the field: http://www.джумла-тест.рф/master
will be saved in the db as:
http://www.xn----7sblgc4ag8bhcd.xn--p1ai/master
and will still display in the field as:
http://www.джумла-тест.рф/master

When it is used in a page, it is the punycoded version stored in the db which is used as url link or mailto.
So we will see:
screen shot 2015-07-27 at 08 39 42

but the source will be:

        <span class="contact-webpage">
            <a href="http://www.xn----7sblgc4ag8bhcd.xn--p1ai/master" target="_blank" itemprop="url">
            http://www.джумла-тест.рф/master</a>
        </span>
avatar brianteeman brianteeman - change - 28 Jul 2015
Category ⇒ External Library
avatar infograf768
infograf768 - comment - 30 Jul 2015

Found a small issue which is not related to this patch when displaying contact profile in front-end.

Website:</label></dt><dd><a href="http://www.xn----7sblgc4ag8bhcd.xn--p1ai/index.php">http://www.xn----7sblgc4ag8bhcd.xn--p1ai/index.php</a></dd>       </dl>

Will try to find where it is done.

avatar infograf768
infograf768 - comment - 30 Jul 2015

See #7585

avatar wilsonge wilsonge - change - 24 Aug 2015
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2015
Labels Added: ?
431b8ea 26 Oct 2015 avatar dgt41 init
avatar mbabker mbabker - close - 27 Oct 2015
avatar mbabker
mbabker - comment - 27 Oct 2015

Resubmitting against staging.

avatar mbabker mbabker - change - 27 Oct 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-27 23:57:21
Closed_By ⇒ mbabker
avatar mbabker mbabker - head_ref_deleted - 30 Oct 2015

Add a Comment

Login with GitHub to post a comment