[#7312] - Regression Smart search/contact list menu item cannot been saved
- Closed
- 2 Jul 2015
- Urgent
- Build: staging
- # 7312
- Diff
- dgt41:__finder_menu_regression
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This fixes #7309, #7308
Steps to reproduce the issue
Create a new menu item for Smart Search
Expected result
Menu link created
Actual result
Invalid field: Date Filters
Invalid field: Advanced Search
Invalid field: Expand Advanced Search
Testing
Apply patch and follow the instructions above. Menu item should be saved without any errors
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
deleted.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-02 08:12:10 |
| Closed_By | ⇒ | Bakual |
Ah crap, commented in wrong PR 
| Status | Closed | ⇒ | New |
| Closed_Date | 2015-07-02 08:12:10 | ⇒ | |
| Closed_By | Bakual | ⇒ |
Are you sure this is the cause of the issue? The last time this file was updated was #6294 which as far as I can tell was in 3.4.1
I havent checked yet but I suspect that #6664 and the changes in core.js are more likely
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7312.
| Title |
|
||||||
| Title |
|
||||||
| Priority | Medium | ⇒ | Urgent |
I suspect that the issue with the farsi calendar is also as a result of the same changes in core.js
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7312.
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | JavaScript |
| Status | New | ⇒ | Pending |
We can now solve the Farsi calendar issue. See:
#7298 (comment)
Reverting 516a864
516a864
solves
the issue
On 2 July 2015 at 10:37, Fedir Zinchuk notifications@github.com wrote:
as far as I can see, error comes from the server side validation ... but
cannot find why ...
maybe it somehow related to this changes 516a864
516a864—
Reply to this email directly or view it on GitHub
#7312 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman was faster
Note its also the contact list menu type thats effected (maybe others)
On 2 July 2015 at 10:40, Fedir Zinchuk notifications@github.com wrote:
@brianteeman https://github.com/brianteeman was faster [image:
—
Reply to this email directly or view it on GitHub
#7312 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@infograf768 true, but at least we know a reason 
I am just stating that the issue is definitely as a result of the changes
made in that PR. It is for others to decide if it should be reverted or if
it can be fixed in another way.
On 2 July 2015 at 10:43, infograf768 notifications@github.com wrote:
Revert is a possibility indeed, but it would break I guess the original
issue solved by #3877 #3877—
Reply to this email directly or view it on GitHub
#7312 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@okonomiyaki3000 as it was your PR can you get a look into here?
As the PR that is causing the issue is over 18 months old and was to enable
something for 3pd then I would definitely say revert the PR and wait for a
different solution for that specific issue
On 2 July 2015 at 10:50, zero-24 notifications@github.com wrote:
@okonomiyaki3000 https://github.com/okonomiyaki3000 as it was your PR
can you get a look into here?—
Reply to this email directly or view it on GitHub
#7312 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
As the PR that is causing the issue is over 18 months old
That is exactly why imho we can't just revert it as 3pd may have used that code since...
Forget it. It was just recently merged...
;)
On 2 July 2015 at 11:01, infograf768 notifications@github.com wrote:
Forget it. It was just recently merged...
—
Reply to this email directly or view it on GitHub
#7312 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-02 12:28:36 |
| Closed_By | ⇒ | zero-24 |
| Milestone |
Removed: |
||
Patch doesn't work for me. And yes, cache was cleared. Even tried with debug on so I got the uncompressed file. Same result.