[#7257] - New feature: allow local URI rules
- Closed
- 24 Jun 2015
- Medium
- Build: staging
- # 7257
- Diff
- podlom:staging
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
This simple patch allows user to create redirect rules based on local URIs.
It is very useful then you migrate from one domain to another.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Test instructions:
- Behavior before patch: local URI redirects without domain name starting with / does not work.
- Behavior after patch: local URI redirects without domain name starting with / does work.
@podlom Thank you for your contribution. This additional check is already implemented (starting from line 88 // If no published redirect was found try with the server-relative URL), so your proposal is redundant and not required. I will close this PR, feel free to comment on it and request a reopening.
A more interesting change would be that the plugin saves the URLs relatively, this would make the domain changing process easier!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-24 10:16:44 |
| Closed_By | ⇒ | Kubik-Rubik |
Thank you, @Kubik-Rubik
I think we shouldn't change anything in user input.
If he wants to save full URL - it should be done.
If he wants to save relative URI it should work as well as full URL.
Please provide a full set of instructions to enable people to test this. This should include the behaviour before and after the patch