? Success
Pull Request for # 7169

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
23 Jun 2015

This PR fixes a bug reported by @Nzara in #7169. Detailed description and testing instructions can be found in that issue.

avatar wojsmol wojsmol - open - 23 Jun 2015
avatar wojsmol wojsmol - change - 23 Jun 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 24 Jun 2015

@test success, works fine for me. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7256.

avatar n9iels n9iels - test_item - 24 Jun 2015 - Tested successfully
avatar wojsmol
wojsmol - comment - 24 Jun 2015

@n9iels thanks for testing, need another tester :smile:

avatar Bakual Bakual - change - 24 Jun 2015
Title
fix joomla/joomla-cms#7169
Missing grouping label on mod_articles_category
avatar Bakual
Bakual - comment - 24 Jun 2015

Adjusted title of PR.
Description copied from Issue


Steps to reproduce the issue

  • create some categories, let say cat_a, cat_b
  • create some articles in these categories, let's say: A, B, C
  • create a module of type Articles - Category
    • choose option Filtering Options:Category: all_categories
    • choose option Grouping Options:Article Grouping: Category
    • choose an appropriate position to make it visible in your template
  • view output of module on front end

Expected result

Name of Module

  • Cat_a
    • A
    • B
  • Cat_b
    • C

Actual result

Name of Module

    • A
    • B
    • C

Additional comments

After learning php i could work around by creating an overwrite of htm/mod_arcticles_category/default.php. Just insert after line 16:

<div class="mod-articles-category-group"><?php echo $group_name;?></div>

I feel, this should be part of the core release.

avatar zero-24 zero-24 - change - 24 Jun 2015
Category Front End Modules
avatar zero-24 zero-24 - change - 24 Jun 2015
Title
fix joomla/joomla-cms#7169
Missing grouping label on mod_articles_category
Rel_Number 0 7169
Relation Type Pull Request for
Easy No Yes
avatar jwaisner
jwaisner - comment - 27 Jun 2015

@test

PR works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7256.

avatar jwaisner jwaisner - test_item - 27 Jun 2015 - Tested successfully
avatar wojsmol
wojsmol - comment - 27 Jun 2015

@n9iels @jwaisner thanks for testing
@zero-24 we have 2 good tests, RTC?

avatar brianteeman
brianteeman - comment - 27 Jun 2015

Setting RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7256.

avatar brianteeman brianteeman - test_item - 27 Jun 2015 - Tested successfully
avatar brianteeman brianteeman - change - 27 Jun 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 27 Jun 2015
Labels Added: ?
avatar wojsmol
wojsmol - comment - 1 Jul 2015

Can I expect that this PR will be merged to 3.4.3?

avatar Bakual
Bakual - comment - 1 Jul 2015

Can I expect that this PR will be merged to 3.4.3?

Depends if 3.4.3 will be a hotfix for major issues popping up in 3.4.2 or a regular release. If the latter, then chances are high.

avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - close - 3 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - close - 3 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-03 10:16:28
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 3 Jul 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Jul 2015

Thank you @wojsmol for providing the fix and @Nzara for reporting the issue! Merged.

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment