? Success
Pull Request for # 7227

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
21 Jun 2015

This is my approach to fix the problem described here: #7227
This patch also avoids the problem with not valid templates from this pull request: #7228

This PR will only load a template if it is a valid template (-> it exists and is enabled) else the specified template is loaded.

How to test

1.) Add ?template= and then ?template=xyz (not valid template name) to the end of the frontpage (this should load the default Beez3 template, IMHO not a good fallback solution...)
2.) Deactivate the template Beez3 (Extensions - Extensions - Manage - Status) and try it again, both tries will result in an error message on blank page
3.) Apply this PR (with Patchtester component) and try it again. The correct (selected) template will be loaded on both tries!

avatar Kubik-Rubik Kubik-Rubik - open - 21 Jun 2015
avatar Kubik-Rubik Kubik-Rubik - change - 21 Jun 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2015
Labels Added: ?
avatar MAT978
MAT978 - comment - 21 Jun 2015

test
works as described for both '?template=' and for a non-existant template.
and: with and without the template unabled
Thanks

avatar MAT978 MAT978 - test_item - 21 Jun 2015 - Tested successfully
avatar jwaisner
jwaisner - comment - 21 Jun 2015

@test

PR works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7229.

avatar jwaisner jwaisner - test_item - 21 Jun 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Jun 2015

All good to me - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7229.

avatar brianteeman brianteeman - test_item - 21 Jun 2015 - Tested successfully
avatar brianteeman brianteeman - change - 21 Jun 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 21 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 22 Jun 2015
Category Libraries
avatar zero-24 zero-24 - change - 22 Jun 2015
Easy No Yes
avatar zero-24 zero-24 - change - 22 Jun 2015
Rel_Number 0 7227
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - close - 9 Jul 2015
avatar roland-d roland-d - close - 9 Jul 2015
avatar roland-d roland-d - reference | c9bba89 - 9 Jul 15
avatar roland-d roland-d - merge - 9 Jul 2015
avatar roland-d roland-d - close - 9 Jul 2015
avatar roland-d roland-d - change - 9 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-09 19:00:10
Closed_By roland-d
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment