[#7228] - Make sure template value is not empty
- Closed
- 23 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 7228
- Diff
- mbabker:templateVar
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See #7227 for details.
This catches if the value ends up being empty and restores the value returned from the lookup a few lines above this.
Hi there. Check this http://www.joomla.org/?template=
It looking not good in main Joomla site.
I have checked this at my projects - yea, looks like bad bug, when you add ?template after joomlasiteurl/
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries Templates (site) |
| Rel_Number | 0 | ⇒ | 7227 |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
Well, that's correct in some ways. Since we have the feature in there to change the template based on the query variable, the current system behavior is to fallback to beez3 if the requested template doesn't exist. Separate PR IMO, but if that situation is to be handled, then there should be a two level fallback which tries to use the site default template (if $requestTemplate !== $siteTemplate) then falls back to beez3.
test works here, except non-existent template
what about fallback to system template, that will render only component section, or also bad idea?
The fallback system requires a template style to be defined, the system template doesn't have one. One would need to investigate whether using it would cause an issue or not.
Can this option be closed in favour of #7229 which is more complete
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7228.
Closing as #7229 is RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7228.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-23 07:58:27 |
| Closed_By | ⇒ | brianteeman |
This works as described BUT the issue still exists for a non-existant template
eg ?template=mbabker
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7228.