[#7167] - Load mootools modal in layouts only if needed
- Closed
- 11 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7167
- Diff
- dgt41:__more_mootools
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Conservative loading of mootools modal
Core editor xtd plugins call mootools modal way to early in the process, but we can differ this to layout and actually load it only if the plugin is actually a modal!
This should be 100% B/C
TESTING
Apply this patch and create a new Article. Observe any console error and that functionality of all buttons remains the same!
Apply also #7152, #5871, #5655, #5654 and try to create a new article. Observe that no mootools is loaded! Test functionality
Install some 3rd party dev xtd plugins and try their functionality and look for console logged errors
brianteeman
- | Labels |
Added:
?
|
||
Fedik
- | Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Category | ⇒ | JavaScript |
In addition, #7152 is closed and I didn't apply it for the test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.
@anibalsanchez A new replacement for #7152 will come soon!
@dgt41 can we RTC or do we need to test also on the replacement for #7152 bevor RTC?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.
| Status | Pending | ⇒ | Ready to Commit |
RTC 
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
mbabker
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 14:59:46 |
| Closed_By | ⇒ | mbabker |
| Labels |
Removed:
?
|
||
#Test OK
One step closer to drop mootools. Congratlations!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.