? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
13 Jun 2015

Conservative loading of mootools modal

Core editor xtd plugins call mootools modal way to early in the process, but we can differ this to layout and actually load it only if the plugin is actually a modal!
This should be 100% B/C

TESTING

Apply this patch and create a new Article. Observe any console error and that functionality of all buttons remains the same!

Apply also #7152, #5871, #5655, #5654 and try to create a new article. Observe that no mootools is loaded! Test functionality

Install some 3rd party dev xtd plugins and try their functionality and look for console logged errors

avatar dgt41 dgt41 - open - 13 Jun 2015
avatar brianteeman brianteeman - change - 14 Jun 2015
Labels Added: ?
avatar Fedik Fedik - test_item - 14 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 14 Jun 2015
Status New Pending
Easy No Yes
avatar zero-24 zero-24 - change - 14 Jun 2015
Category JavaScript
avatar anibalsanchez
anibalsanchez - comment - 14 Jun 2015

#Test OK

One step closer to drop mootools. Congratlations!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.

avatar anibalsanchez anibalsanchez - test_item - 14 Jun 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 14 Jun 2015

In addition, #7152 is closed and I didn't apply it for the test


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.

avatar dgt41
dgt41 - comment - 14 Jun 2015

@anibalsanchez A new replacement for #7152 will come soon!

avatar zero-24
zero-24 - comment - 14 Jun 2015

@dgt41 can we RTC or do we need to test also on the replacement for #7152 bevor RTC?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.

avatar dgt41
dgt41 - comment - 14 Jun 2015

@zero-24 you can RTC it

avatar zero-24 zero-24 - change - 15 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 15 Jun 2015

RTC :smile: Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7167.

avatar zero-24 zero-24 - change - 15 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar mbabker mbabker - merge - 11 Jul 2015
avatar zero-24 zero-24 - close - 11 Jul 2015
avatar mbabker mbabker - close - 11 Jul 2015
avatar mbabker mbabker - reference | 1733c51 - 11 Jul 15
avatar mbabker mbabker - close - 11 Jul 2015
avatar mbabker mbabker - change - 11 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-11 14:59:46
Closed_By mbabker
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment