[#7094] - Password: Fix for Firefox as autocomplete=off does not work [fix for #7054]
- Closed
- 3 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 7094
- Diff
- infograf768:FF_autocomplete
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This fixes #7054
The password field is filled even when it is only optional thus forcing to enter a value in the Confirm Password field. As this is not expected by the user, the error "Invalid field: Confirm Password" displays.
To test:
3 instances:
1. Edit a user (editing yourself as superuser) through User Manager.
2. Editing your own profile in back-end
3.Editing your own profile in front-end
In these 3 cases, you will see that the password field contains a value.
Patch and retest, then save any user parameter without touching at the passwords fields. Now should be OK.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Category | ⇒ | UI/UX |
I tested on FF, IE, Chrome, Safari and for me all is ok.
Thank you very much for your PR
| Status | Pending | ⇒ | Ready to Commit |
Thanks here 
I mark this RTC now.
@infograf768 can you have a look into the comment by @dgt41? as it is just a cosmetic one ;)
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7094.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-03 10:00:45 |
| Closed_By | ⇒ | Bakual |
Merged into stagng. Thanks!
johanjanssens
- | Labels |
Removed:
?
|
||
This does not seem to work anymore
Replace
<?php // Disables autocomplete ?> <input type="text" style="display:none">
with:
<?php // Disables autocomplete ?> <input type="password" style="display:none">
You want to do a PR for that?
Yes i will make a new PR
While you are at it, I suggest you add it to installation
diff --git a/installation/view/site/tmpl/default.php b/installation/view/site/tmpl/default.php
index 8a46e6c..661aad9 100644
--- a/installation/view/site/tmpl/default.php
+++ b/installation/view/site/tmpl/default.php
@@ -79,4 +79,5 @@
</div>
<div class="controls">
+ <input type="password" style="display:none">
<?php echo $this->form->getInput('admin_password'); ?>
<p class="help-block"><?php echo JText::_('INSTL_ADMIN_PASSWORD_DESC'); ?></p>
@@ -88,4 +89,5 @@
</div>
<div class="controls">
+ <input type="password" style="display:none">
<?php echo $this->form->getInput('admin_password2'); ?>
</div>
And also for database
diff --git a/installation/view/database/tmpl/default.php b/installation/view/database/tmpl/default.php
index 3cb8eab..2552e64 100644
--- a/installation/view/database/tmpl/default.php
+++ b/installation/view/database/tmpl/default.php
@@ -60,4 +60,5 @@
</div>
<div class="controls">
+ <input type="password" style="display:none">
<?php echo $this->form->getInput('db_pass'); ?>
<p class="help-block">
@infograf768
you have better knowledge of the places this is needed
- maybe it is more easy for you to make this PR ?
a note about the suggested fix, it is suggested in recent forum thread i have read and i have tested it successfully in custom component too
sure i will make during weekend :-)
Forgot, we should also add autocomplete off to the database password field:
diff --git a/installation/model/forms/database.xml b/installation/model/forms/database.xml
index 4fd4508..ecb67af 100644
--- a/installation/model/forms/database.xml
+++ b/installation/model/forms/database.xml
@@ -23,4 +23,5 @@
<field name="db_pass" type="password" id="db_pass" class="inputbox"
label="INSTL_DATABASE_PASSWORD_LABEL"
+ autocomplete="off"
filter="raw"
/>
Note: to test, the password has to be saved first.