? Success

User tests: Successful: Unsuccessful:

avatar pjmatos
pjmatos
1 Jun 2015

Quick workaround to allow multiple editor instances on the same page to have a readmore break.
Without this workaround, only one of the editors was allowed to have a readmore break.

avatar pjmatos pjmatos - open - 1 Jun 2015
avatar zero-24 zero-24 - change - 1 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 1 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 1 Jun 2015
Category Plugins
avatar zero-24 zero-24 - change - 1 Jun 2015
Status New Pending
avatar shre001
shre001 - comment - 7 Jun 2015

@test works fine


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7093.

avatar shre001 shre001 - test_item - 7 Jun 2015 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Jun 2015

@test

PR works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7093.

avatar jwaisner jwaisner - test_item - 11 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 11 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 11 Jun 2015

RTC :smile: Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7093.

avatar zero-24 zero-24 - change - 11 Jun 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 11 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-11 16:00:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Jun 2015
avatar zero-24 zero-24 - close - 11 Jun 2015
avatar dgt41
dgt41 - comment - 24 Jun 2015

@pjmatos Can i ask what is the possible use case for this change? I mean multiple read more cannot exist in one article, so I try to figure out how this is gonna be used without actually cause some harm (e.g. in K2)

avatar pjmatos
pjmatos - comment - 25 Jun 2015

@dgt41 This change applies to pages that have more than one editor. A Joomla article has only one editor, so the maximum number of read more breaks will continue to be just one. If there is any page with multiple editor instances (e.g. a page that has multiple tabs and at least more than one tab has an editor), then this fix will allow each editor to have one and no more than one read more break. Without this fix, only one read more break would be allowed among all the editor instances of a given page. In what case scenario do you suspect that this might break something in K2?

avatar wilsonge
wilsonge - comment - 25 Jun 2015

This PR is responsible for the issue described in: #7260 :(

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment