Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7072] - Contacts - move Filters from left to [Search Tools] #6951

? Success
Related to # 6951

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
30 May 2015

I had a merge conflict & redid the changes.
Please see #6951 for test.

This PR moves the 5 Filter options of the Contacts Manager to the [Search Tools] button.
note: The ordering dropdown in [Search Tools] needs to be fixed before merging.
(See Issue #6941 regarding the inconsistency with Filter options).

Test instructions

In back-end > Components > Contacts
See the filters on the left

screen shot 2015-05-15 at 06 37 24

Compare with the filters in Category Manager for Contacts:
In back-end > Components > Contacts > Categories

screen shot 2015-05-15 at 06 37 23

This PR changes moves the Filters

from the left to the middle column and will be visible when you click on the [Search Tools] button.

screen shot 2015-05-15 at 06 37 23

Notes:

I can use some help & suggestions regarding the following issues:

  • The ordering dropdown in [Search Tools] is currently not working
  • Code cleanup 1 - tmpl view ( /administrator/components/com_tags/views/tags/tmpl/default.php ) contains "Joomla.orderTable = function()" that probably can be removed
avatar pe7er pe7er - open - 30 May 2015
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 May 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 30 May 2015
The description was changed
Status New ⇒ Pending
Rel_Number 0 ⇒ 6951
Relation Type ⇒ Related to
avatar infograf768
infograf768 - comment - 31 May 2015

not tested but code style:

        if ($canDo->get('core.create') || (count($user->getAuthorisedCategories('com_contact', 'core.create'))) > 0) {
            JToolbarHelper::addNew('contact.add');
        }

should be

        if ($canDo->get('core.create') || (count($user->getAuthorisedCategories('com_contact', 'core.create'))) > 0)
        {
            JToolbarHelper::addNew('contact.add');
        }
avatar brianteeman brianteeman - change - 27 Jun 2015
Title
…
Redo of all corrections of #6951 because of merge conflict
Contacts - move Filters from left to [Search Tools] #6951
avatar brianteeman brianteeman - change - 27 Jun 2015
Title
…
Redo of all corrections of #6951 because of merge conflict
Contacts - move Filters from left to [Search Tools] #6951
avatar brianteeman
brianteeman - comment - 27 Jun 2015

Updated the title to more meaningful

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7072.

avatar peterlose
peterlose - comment - 14 Jul 2015

Tested. Seems to work fine. Could you look at the CS @pe7er ?

avatar ramya185
ramya185 - comment - 25 Jul 2015

Tested on chrome Version 43.0.2357.134.
Worked fine. #jqConf15

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7072.

avatar ramya185 ramya185 - test_item - 25 Jul 2015 - Tested successfully
avatar brianteeman brianteeman - alter_testresult - 25 Jul 2015 - peterlose: Tested successfully
avatar brianteeman
brianteeman - comment - 25 Jul 2015

When the codestyle issues have been resolved this can be moved to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7072.

avatar zero-24
zero-24 - comment - 4 Aug 2015

here is a PR that should fix the CS issues: pe7er#3

avatar pe7er
pe7er - comment - 16 Aug 2015

Thanks for the fix @zero-24!

avatar zero-24 zero-24 - change - 16 Aug 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 16 Aug 2015

RTC Thanks @pe7er

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7072.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar roland-d
roland-d - comment - 23 Oct 2015

@pe7er Can you please fix the merge conflicts?

avatar pe7er
pe7er - comment - 24 Oct 2015

@roland-d The functionality of this PR seems to be merged in 4.6dev already with a later PR #7995 from someone else...

avatar zero-24
zero-24 - comment - 24 Oct 2015

Ok so I close here.

avatar zero-24 zero-24 - change - 24 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-24 14:10:51
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar zero-24 zero-24 - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment