Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6951] - Contacts - move Filters from left to [Search Tools]

? ?
Related to # 6941
Referenced as Related to: # 7072

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
15 May 2015

[edit] I had a merge conflict and redid the changes in new PR.
Please test #7072 instead. Thanks!

This PR moves the 5 Filter options of the Contacts Manager to the [Search Tools] button.
note: The ordering dropdown in [Search Tools] needs to be fixed before merging.
(See Issue #6941 regarding the inconsistency with Filter options).

Test instructions

In back-end > Components > Contacts
See the filters on the left

screen shot 2015-05-15 at 06 37 24

Compare with the filters in Category Manager for Contacts:
In back-end > Components > Contacts > Categories

screen shot 2015-05-15 at 06 37 23

This PR changes moves the Filters

from the left to the middle column and will be visible when you click on the [Search Tools] button.

screen shot 2015-05-15 at 06 37 23

Notes:

I can use some help & suggestions regarding the following issues:

  • The ordering dropdown in [Search Tools] is currently not working
  • Code cleanup 1 - tmpl view ( /administrator/components/com_tags/views/tags/tmpl/default.php ) contains "Joomla.orderTable = function()" that probably can be removed
avatar pe7er pe7er - open - 15 May 2015
avatar pe7er pe7er - change - 15 May 2015
The description was changed
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 15 May 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 15 May 2015
Status New ⇒ Pending
Rel_Number 0 ⇒ 6941
Relation Type ⇒ Related to
Easy No ⇒ Yes
avatar brianteeman
brianteeman - comment - 25 May 2015

I dont see the value in having the new tag filter as there is no way to see the tags in the list

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6951.

avatar brianteeman
brianteeman - comment - 25 May 2015

Although as I see it is already present before this PR it should probably stay
So i am marking this as a successful test

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6951.

avatar brianteeman brianteeman - test_item - 25 May 2015 - Tested successfully
avatar bertmert
bertmert - comment - 25 May 2015

@test Order-By drop down failed.

@pe7er
Remove these lines in .../tmpl/default.php

<input type="hidden" name="filter_order" value="<?php echo $listOrder; ?>" />
<input type="hidden" name="filter_order_Dir" value="<?php echo $listDirn; ?>" />
avatar bertmert
bertmert - comment - 25 May 2015

@test Tag filter doesn't work correctly.

Scenario 1:

  • Logout from backend. Delete cookies [= kill session]. Clear browser cache.
  • Login and go directly to Contacts Manager ==> Search tools bar is open.

Scenario 2:

  • Select a tag in search tools bar (nothing else!!)
  • Search tools bar disappears
avatar bertmert
bertmert - comment - 25 May 2015

@pe7er
Fix for Scenario 2.
Add 'tag' to $config['filter_fields'] in constructor of model.

avatar bertmert
bertmert - comment - 25 May 2015

@pe7er
Fix for Scenario 1 (but not tested if this colides with Hathor)

In model method populateState() change line

$access = $this->getUserStateFromRequest($this->context . '.filter.access', 'filter_access');
avatar pe7er
pe7er - comment - 26 May 2015

Great! Thanks @bertmert !
I'll try your fixes after this weekend (or during the weekend at JandBeyond)

avatar pe7er
pe7er - comment - 30 May 2015

I've corrected the order dropdown + problem with filter after filtering on Tags only with the fix from @bertmert.
Thanks @bertmert for this fix!

avatar pe7er
pe7er - comment - 30 May 2015

I corrected the problem with open search filter with solution from @bertmert

#6951 (comment)
Thanks!

avatar m-b-o m-b-o - test_item - 30 May 2015 - Tested successfully
avatar pe7er pe7er - reference | ca0ccce - 30 May 15
avatar pe7er pe7er - reference | f3b9e44 - 30 May 15
avatar pe7er pe7er - reference | b75b4f8 - 30 May 15
avatar pe7er
pe7er - comment - 30 May 2015

I had a merge conflict and redid the changes in new PR.
Please test #7072 instead. Thanks!

avatar zero-24 zero-24 - close - 30 May 2015
avatar zero-24
zero-24 - comment - 30 May 2015

I'm just closing here and just copied the instructions as we have a new PR #7072 Thanks :+1:

avatar zero-24 zero-24 - change - 30 May 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-05-30 16:49:30
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 30 May 2015
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment