? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
21 May 2015

This is the rest of #7000

What is changed:
1. modals are properly rendered through the API
2. overrides have only the actual content (no hard coded structure)
3. obey to ACL
4. modal is rendered only if items exist
5. process button class from primary to success (color change from blue to green)

testing

You need to test the batch functionality for these urls
administrator/index.php?option=com_users&view=users
administrator/index.php?option=com_categories&extension=com_content
administrator/index.php?option=com_content&view=articles
administrator/index.php?option=com_menus&view=items&menutype=mainmenu
administrator/index.php?option=com_contact
administrator/index.php?option=com_newsfeeds
administrator/index.php?option=com_redirect
administrator/index.php?option=com_tags

Preview

screen shot 2015-05-21 at 2 31 47
screen shot 2015-05-21 at 2 33 24
screen shot 2015-05-21 at 2 34 16
screen shot 2015-05-21 at 2 35 02
screen shot 2015-05-21 at 2 36 25
screen shot 2015-05-21 at 2 37 07
screen shot 2015-05-21 at 2 37 50
screen shot 2015-05-21 at 2 38 58

bb9e0a1 21 May 2015 avatar dgt41 init
avatar dgt41 dgt41 - open - 21 May 2015
avatar dgt41
dgt41 - comment - 21 May 2015

PS Another PR will cover hathor!

7220f45 21 May 2015 avatar dgt41 oops
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2015
Labels Added: ?
avatar MAT978 MAT978 - test_item - 21 May 2015 - Tested successfully
avatar MAT978
MAT978 - comment - 21 May 2015

@test

#7003 works fine for the reported links


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7003.

avatar smz
smz - comment - 21 May 2015

@dgt41 As in #7000, the width and height options for the modal are redundant and useless: they are only used for iframe modals...

avatar n9iels
n9iels - comment - 21 May 2015

@test something go wrong with the batch modal on com_content
modal contacts
I'm using the latest version of Goolge Chrome and a 23 insh screen.

The other modal looks good to me

avatar dgt41
dgt41 - comment - 21 May 2015

@n9iels should be fine now
screen shot 2015-05-21 at 12 43 22

avatar dgt41
dgt41 - comment - 21 May 2015

@n9iels sorry wrong img
screen shot 2015-05-21 at 7 33 30

avatar smz
smz - comment - 21 May 2015

@dgt41 I have the same issue as @n9iels for com_contacts on FF 38.0.1:
capture

Sorry, but going out now: will be back later tonight.

avatar dgt41
dgt41 - comment - 21 May 2015

@smz Are you sure you purge and re applied this pr? Are you with patch tester or git?
Seems good here
screen shot 2015-05-21 at 8 02 51

avatar smz
smz - comment - 21 May 2015

Yes, purged. Used Patchtester...

avatar MAT978
MAT978 - comment - 21 May 2015

didn't noticed and nothing here (maybe new patch) FF 38.0.1

@test success thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7003.

avatar zero-24 zero-24 - change - 21 May 2015
Status New Pending
avatar zero-24 zero-24 - change - 21 May 2015
Category Administration UI/UX
avatar n9iels
n9iels - comment - 21 May 2015

@test success, problems with the contact modal are solved now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7003.

avatar n9iels n9iels - test_item - 21 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 21 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 21 May 2015

RTC Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7003.

avatar zero-24 zero-24 - change - 21 May 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 22 May 2015

Merged. Thank you @dgt41!

avatar Kubik-Rubik Kubik-Rubik - change - 22 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-22 07:22:16
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 22 May 2015
avatar zero-24 zero-24 - close - 22 May 2015
avatar dgt41
dgt41 - comment - 26 May 2015

@n9iels @MAT978 @smz @Kubik-Rubik I combined the changes of the batch modals for Hathor with another standing PR. If we can test and push #5245 Hathor will be very happy ????

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment