[#6954] - Fix for: zero or negative values on session lifetime.
- Closed
- 3 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 6954
- Diff
- maxvalentini77:fix-zero-negative-session-lifetime
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Zero or negative values on session lifetime
Session lifetime is an integer value and should be setted to a positive value greater than zero.
- Negative value cause that the session to be always "expired".
- Zero behavior is equals to the default value of 15 minute, this behavior is not explict and can be obtained setting 15 minutes of lifetime, so i remove zero from the valid range.
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
I still able to save negative value:
I think problem that there no backend validation for this input,
also filter="integer" allow negative value (that is valid),
min="1" have not much effect at least in my Chrome browser 
same problem with "Cache Time" in same configuration form
@maxvalentini77 I suggest to add filter="uint" as well to the field, though I don't see it as necessary.
@Fedik You are right, I'm working on a server side validation.
@izharaazmi Thanks for the tip!
Added number validator to check min/max range for number fields.
Added the validator to cachetime and session lifetime, both setted with min of 1.
jonnyefftek
- 
ChrisBreaks
- | Status | Pending | ⇒ | Ready to Commit |
RTC based on testing by @ChrisBreaks and @jonnyefftek on #jab15 #makeithappen
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6954.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
@test test resutls are: without patch applied, there's no error displayed and you can enter 0 inside "Session Lifetime " field. After applying the patch if you try to enter 0 as a value inside "Session Lifetime " field, you get this error: "Invalid field: Session Lifetime"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6954.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-03 14:11:01 |
| Closed_By | ⇒ | Bakual |
I wrote xx.x in the attribute because i didn't know in which version this class will be introduced. Now should contain 3.5.0, right?
Correct @maxvalentini77 can you just send a quick PR that fixes that?
Awww. I usually don't look at the doc blocks close enough...
Thomas allready merged it. Thanks| Labels |
Removed:
?
|
||
How to test
Thanks @maxvalentini77
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6954.