? ? Success
Related to # 6941

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
15 May 2015

This PR moves the Filter option of the Redirect Manager: Links to the [Search Tools] button.
(See Issue #6941 regarding the inconsistency with Filter options).

Test instructions

In back-end > Components > Redirects
See the filter "- Select Status-" on the left
Also notice that the Expired URL column is too small.

screen shot 2015-05-15 at 08 46 30

Compare with the other filters, e.g. in Category Manager:
In back-end > Content > Categories

This PR changes moves the Filter

from the left to the middle column and will be visible when you click on the [Search Tools] button.
This PR also fixes the column width of the Expired URL column (now the columns Expired URL, New URL, and Referring Page are all 30%) so that it looks better on a smaller screen.

screen shot 2015-05-15 at 08 46 30

avatar pe7er pe7er - open - 15 May 2015
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 15 May 2015
Status New Pending
Rel_Number 0 6941
Relation Type Related to
avatar pe7er pe7er - change - 15 May 2015
The description was changed
avatar MAT978
MAT978 - comment - 15 May 2015

@test
able to reproduce then #6953 works as described (Travis) - thanks
strange having the left collapse column empty O.o

avatar zero-24
zero-24 - comment - 15 May 2015

@pe7er i have just tested this.

here my result.
pr_6953

I hope we are able to remove the side bar as it looks very bad.
The seccond thing i marked is the info box are we abel to add a bit space between the searchtools and the message? If searchtools are open all is ok but can we have this extra space also if the searchtools are closed?

avatar zero-24
zero-24 - comment - 15 May 2015

Also i have just noted that the filter don't work. It will be shown but don't work here. If i change to e.g. unpublished i still get all also the publiched etc.

avatar bertmert
bertmert - comment - 15 May 2015

@pe7er
To remove sidebar you need an empty one in tmpl/default.php. Remove line

$this->sidebar = JHtmlSidebar::render();

in view.html.php.

avatar bertmert
bertmert - comment - 15 May 2015

@pe7er
To make filter work you have 1) to change
name="published"
to
name="state"
in filter,,,.xml.

And you have 2) to add state to config_fields in constructor of model

'published', 'a.published', 'state'
avatar pe7er pe7er - reference | 16dbec4 - 16 May 15
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 17 May 2015

Thank you all for testing.
I've committed the PR from @zero-24 to fix a CS issue,
and after changing the field name in the filter.xml (thanks @bertmert !) the filter works correctly.
Do I still need to add "config_fields" to the constructor of the model?

I also added a "Links" submenu so that (although this component has just 1 view) the view is consistent with all other components.
screen shot 2015-05-17 at 07 58 10


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6953.

avatar jwaisner
jwaisner - comment - 23 May 2015

@test

Menu on left contains "Links" now. "Search Tools" works when filtering. Spacing between "search tools" and the below message still is not corrected.

screen shot 2015-05-23 at 00 03 19


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6953.

avatar brianteeman
brianteeman - comment - 23 May 2015

I do not understand why there is a sidebar with a link to open the view that you are already on - this serves no purpose at all


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6953.

avatar pe7er
pe7er - comment - 23 May 2015

Consistency & it's a visual aid that makes orientation (especially for new users) easier.

All components that have multiple views (e.g. items & categories) have a sidebar with (sort of) "menu items" where you can easily select another view of that component. Besides selecting "menu options" it also shows the admin which "admin sub menu" they are using.

I've noticed that especially for new users the admin menu structure can be very confusing. The sidebar functions as visual aid that makes orientation easier.

And when you only have one highlighted (blue background) option, it gives admins a visual aid that is consistent with all "multi view" components.

avatar brianteeman
brianteeman - comment - 23 May 2015

I understand you but disagree.
On 23 May 2015 1:35 pm, "Peter Martin" notifications@github.com wrote:

Consistency & it's a visual aid that makes orientation (especially for new
users) easier.

All components that have multiple views (e.g. items & categories) have a
sidebar with (sort of) "menu items" where you can easily select another
view of that component. Besides selecting "menu options" it also shows the
admin which "admin sub menu" they are using.

I've noticed that especially for new users the admin menu structure can be
very confusing. The sidebar functions as visual aid that makes orientation
easier.

And when you only have one highlighted (blue background) option, it gives
admins a visual aid that is consistent with all "multi view" components.


Reply to this email directly or view it on GitHub
#6953 (comment).

avatar bertmert
bertmert - comment - 23 May 2015

I would remove the sidebar, too, because any unneccessary rendering ist a waste of time and performance. Every little helps...

avatar larapetersen
larapetersen - comment - 11 Jul 2015

Tested succesfully. I agree however, that the sidebar is only useful when an item has subitems. With Redirect, that's not the case. And why use the term "Links" and not "Redirect"?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6953.

avatar larapetersen larapetersen - test_item - 11 Jul 2015 - Tested successfully
avatar genesisfan
genesisfan - comment - 11 Jul 2015

@test succesfully tested. No sidebar necessary IMHO.
The space between searchtools and message bar should be fixed?

space


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6953.

avatar genesisfan genesisfan - test_item - 11 Jul 2015 - Tested successfully
avatar roland-d
roland-d - comment - 11 Jul 2015

I also agree the sidebar is useless on the redirect manager. @pe7er Can you please update your PR? It seems to have some issues as well.

avatar zero-24 zero-24 - change - 11 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 31 Jul 2015
Status Pending Information Required
avatar zero-24
zero-24 - comment - 31 Jul 2015

Moving to Information Required until @pe7er get the time to change the Code as @roland-d sugsested.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6953.

avatar zero-24 zero-24 - alter_testresult - 31 Jul 2015 - genesisfan: Not tested
avatar zero-24 zero-24 - alter_testresult - 31 Jul 2015 - larapetersen: Not tested
avatar pe7er pe7er - reference | e0984d4 - 16 Aug 15
avatar pe7er
pe7er - comment - 16 Aug 2015

I tried to update this PR but had some "HEAD detached" problems & merge conflicts.
Therefore I've created a new PR. Could someone please merge this with the new PR #7697
Thanks!

avatar zero-24
zero-24 - comment - 17 Aug 2015

Closing as we have a new & updated.

avatar zero-24 zero-24 - change - 17 Aug 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-08-17 07:08:54
Closed_By zero-24
avatar zero-24 zero-24 - close - 17 Aug 2015
avatar zero-24 zero-24 - change - 17 Aug 2015
Milestone Removed:
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment