[#6919] - Disable JS generation in JHtmlBoostrap::Modal()
- Closed
- 11 Jul 2015
- Medium
- Build: staging
- # 6919
- Diff
- smz:JHtmlBootstrapModal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This method was used by the old JHtmlBoostrap::renderModal() implementation.
Since the new implementation it is unneeded and the broken JS it was injecting could create isssues.
zero-24
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript Libraries |
| Status | New | ⇒ | Pending |
I would leave here static::framework(); for b/c reason,
because in theory some extension could call this method, but do not call boostrap.framework
TBH, I think anyone using JHtmlBoostrap::modal() just to load JQuery and bootstrap.min.js and then not using any of the other JHtmlBoostrap methods (all of them have a call to framework()), should burn in J! developer's hell (i.e. port Joomla! to another programming language of his/her choice bewteen COBOL, Lisp or APL), but if there is a consensus this must be done, I'll bow to the B/C god and re-instate it...
Personally, I'm fine with this as is.
... remember the test flag in http://issues.joomla.org/tracker/joomla-cms/6919 or I'm afraid it will not be taken into account...
#test confirmed. JHtmlBootstrap::modal() does nothing!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6919.
We have 2 test: RTC?
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
Setting RTC. Probably should go into 3.5.
| Status | Pending | ⇒ | Ready to Commit |
I think this can go with 3.4.2: the deprecation was already there at 3.4.0 and this just eliminate some useless and potentially dangerous Javascript.
... but that isn't much important either, at least to me! 
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 14:26:20 |
| Closed_By | ⇒ | mbabker |
| Labels |
Removed:
?
|
||
As a case, please see #6918
If conecptually accepted, I don't think this need much testing...