User tests: Successful: Unsuccessful:
Thanks @Erftralle for reporting issue in #6080 (comment)
Please follow the instructions given in #6080 to reproduce the issue.
You can set startOffset
and enable useCookie
by setting options shown as below.
$options = array(
'startOffset' => 3,
'useCookie' => true
);
// Using options
echo JHtml::_('tabs.start', 'pane', $options);
Please also check and confirm that it's not breaking backward compatibility.
Status | New | ⇒ | Pending |
Rel_Number | 0 | ⇒ | 6080 |
Relation Type | ⇒ | Related to |
Labels |
Added:
?
|
Labels |
Added:
?
|
Category | ⇒ | JavaScript Libraries |
Easy | No | ⇒ | Yes |
Thanks @Erftralle for testing.
Yes, is useCookie
is false
then tabs will not be remembered in browser local storage or cookie.
Thanks @Erftralle for testing.
Unfortunately for me it was not a succesfull one :( .
Yes, is useCookie is false then tabs will not be remembered in browser local storage or cookie.
Yes, I know that. Is this answer related to my previous post? If yes, I don't understand you. I was talking about another test case and a different behaviour I would expect.
Ahh ok. Then I think didn't understand your question clearly. Is another bug found?
As per my opinion Test cases would be like,
Seems that we disagree about the expected behaviour of the third test case you mentioned (useCookie => true and startOffset > 0).
Lets see if there are other testers having an opinion to that point.
I cannot reproduce, as tab3 is opened after the reload (after first selecting tab1 & tab2); no patch applied.
Same here, I cannot reproduce the issue (tried in com_search).
@Erftralle @josien @slibbe can you guys try it again. There was an issue in default behaviour of using storage. By Default storage is not enabled.
Thanks for your tests.
Okay, we had a big discussion on this at PBF 2 in JUG Munich. It is working as expected, but are you sure on this?
Issues:
1.) IF you want to have the first (0) to be open this is not possible, offset is ignored when you use cookie and offset is zero.
2.) useCookie has no use if start offset is greater then zero.
From a developer perspective this is irritating!
I have tested this item successfully on 17541d4
I have tested this item successfully on 17541d4
I see it like @yvesh
Status | Pending | ⇒ | Needs Review |
Needs Review
so a Maintainer can take the decision on your points. Thanks
Thank you @gunjanpatel! We decided to merge this PR.
Status | Needs Review | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 11:54:25 |
Closed_By | ⇒ | Kubik-Rubik |
Milestone |
Added: |
Thanks you all for testing and merging.
After applying the patch and using your sample code always Tab4 will be opened.
But what I would expect when using
is that Tab4 is shown on initial page load (localStorage or cookie not yet set) and then the last selected tab on all subsequent page loads.