? Success
Related to # 6080

User tests: Successful: Unsuccessful:

avatar gunjanpatel
gunjanpatel
7 May 2015

Thanks @Erftralle for reporting issue in #6080 (comment)

Testing and Reproduce info

Please follow the instructions given in #6080 to reproduce the issue.

You can set startOffset and enable useCookie by setting options shown as below.

$options = array(
    'startOffset' => 3, 
    'useCookie'   => true
);

// Using options
echo JHtml::_('tabs.start', 'pane', $options);

No Backward Compatibility issue

Please also check and confirm that it's not breaking backward compatibility.

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
5.00

avatar gunjanpatel gunjanpatel - open - 7 May 2015
avatar gunjanpatel gunjanpatel - change - 7 May 2015
Status New Pending
avatar gunjanpatel gunjanpatel - change - 7 May 2015
Rel_Number 0 6080
Relation Type Related to
avatar brianteeman brianteeman - change - 7 May 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 7 May 2015
Category JavaScript Libraries
avatar zero-24 zero-24 - change - 7 May 2015
Easy No Yes
avatar Erftralle
Erftralle - comment - 7 May 2015

After applying the patch and using your sample code always Tab4 will be opened.

But what I would expect when using

$options = array(
    'startOffset' => 3, 
    'useCookie'   => true
);

is that Tab4 is shown on initial page load (localStorage or cookie not yet set) and then the last selected tab on all subsequent page loads.

avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

Thanks @Erftralle for testing.
Yes, is useCookie is false then tabs will not be remembered in browser local storage or cookie.

avatar Erftralle
Erftralle - comment - 9 May 2015

Thanks @Erftralle for testing.

Unfortunately for me it was not a succesfull one :( .

Yes, is useCookie is false then tabs will not be remembered in browser local storage or cookie.

Yes, I know that. Is this answer related to my previous post? If yes, I don't understand you. I was talking about another test case and a different behaviour I would expect.

avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

Ahh ok. Then I think didn't understand your question clearly. Is another bug found?

As per my opinion Test cases would be like,

  • UseCookie => false and startOffset > 0 is given, tab should be selected which is given in startOffset.
  • UseCookie => false and startOffset = 0 (default), then first tab should be selected.
  • UseCookie => true and startOffset > 0 then given tab index in startOffset should be shown as selected (even if you change tab, it should ignore browser storage or cookie when start offset is given)
  • UseCookie => true and startOffset = 0 then it should follow the browser storage or cookie values, mean when you will select tab and refresh the page it will show the tab which was selected before refreshing the page.
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.
avatar Erftralle
Erftralle - comment - 9 May 2015

Seems that we disagree about the expected behaviour of the third test case you mentioned (useCookie => true and startOffset > 0).

Lets see if there are other testers having an opinion to that point.

avatar slibbe
slibbe - comment - 11 Jul 2015

I cannot reproduce, as tab3 is opened after the reload (after first selecting tab1 & tab2); no patch applied.

avatar josien
josien - comment - 11 Jul 2015

Same here, I cannot reproduce the issue (tried in com_search).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.

avatar slibbe slibbe - test_item - 11 Jul 2015 - Tested unsuccessfully
avatar josien josien - test_item - 11 Jul 2015 - Tested unsuccessfully
avatar gunjanpatel
gunjanpatel - comment - 4 Sep 2015

@Erftralle @josien @slibbe can you guys try it again. There was an issue in default behaviour of using storage. By Default storage is not enabled.
Thanks for your tests.

avatar yvesh
yvesh - comment - 24 Oct 2015

Okay, we had a big discussion on this at PBF 2 in JUG Munich. It is working as expected, but are you sure on this?

Issues:

1.) IF you want to have the first (0) to be open this is not possible, offset is ignored when you use cookie and offset is zero.

2.) useCookie has no use if start offset is greater then zero.

From a developer perspective this is irritating!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.

avatar yvesh yvesh - test_item - 24 Oct 2015 - Tested successfully
avatar yvesh
yvesh - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 17541d4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.

avatar degobbis degobbis - test_item - 24 Oct 2015 - Tested successfully
avatar degobbis
degobbis - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 17541d4

I see it like @yvesh


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.

avatar zero-24 zero-24 - change - 24 Oct 2015
Status Pending Needs Review
avatar zero-24
zero-24 - comment - 24 Oct 2015

Needs Review so a Maintainer can take the decision on your points. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.

avatar Kubik-Rubik
Kubik-Rubik - comment - 7 May 2016

Thank you @gunjanpatel! We decided to merge this PR.

avatar Kubik-Rubik Kubik-Rubik - close - 7 May 2016
avatar Kubik-Rubik Kubik-Rubik - merge - 7 May 2016
avatar Kubik-Rubik Kubik-Rubik - reference | c3569e0 - 7 May 16
avatar Kubik-Rubik Kubik-Rubik - merge - 7 May 2016
avatar Kubik-Rubik Kubik-Rubik - close - 7 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 7 May 2016
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-07 11:54:25
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - change - 7 May 2016
Milestone Added:
avatar gunjanpatel
gunjanpatel - comment - 9 May 2016

Thanks you all for testing and merging.

avatar gunjanpatel gunjanpatel - head_ref_deleted - 9 May 2016

Add a Comment

Login with GitHub to post a comment