? Success

User tests: Successful: Unsuccessful:

avatar Erftralle
Erftralle
3 May 2015

Test instructions

  • Go to Menu Manager: New Menu Item
  • Enter a menu title
  • Select Single article for Menu Item Type
  • Do not select any article
  • Click on Save or Save & Close

You will recognize:

  • The system message container just displays the message Error without any hint to the field concerned
  • The field label will not be coloured red
  • If you select an article now the red colouring is not removed

After applaying the patch:

  • The system message container now displays the additional message Invalid field: Select Article
  • The field label will be coloured red
  • After selecting an article the red colouring is removed now

System information

Latest Joomla! staging

If this amendment is agreed I would provide similar changes for the menu types Single contact and Single newsfeed. See also #6654 and #6761 dealing with the same problem.

avatar Erftralle Erftralle - open - 3 May 2015
avatar dgt41
dgt41 - comment - 3 May 2015

@test success

The rendered msg:
screen shot 2015-05-03 at 2 55 22

This is B/C and I think it should be also applied to contact and newsfeed! Thanks @Erftralle

avatar zero-24 zero-24 - change - 3 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 May 2015
Category JavaScript Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 3 May 2015
Status New Ready to Commit
Easy No Yes
avatar zero-24
zero-24 - comment - 3 May 2015

Thanks @Erftralle works great here! Moving RTC :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6885.

avatar zero-24 zero-24 - change - 3 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 May 2015
Labels Added: ?
avatar Erftralle
Erftralle - comment - 3 May 2015

Thanks a lot for testing.

I have created pull requests #6888 and #6889 which apply the same changes to the client side validation of the menu item types Single Contact and Single News Feed.

avatar zero-24 zero-24 - close - 4 May 2015
avatar wilsonge wilsonge - change - 4 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-04 18:33:03
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 May 2015
avatar wilsonge wilsonge - reference | bd2a7bb - 4 May 15
avatar wilsonge wilsonge - merge - 4 May 2015
avatar wilsonge wilsonge - close - 4 May 2015
avatar wilsonge wilsonge - change - 4 May 2015
Milestone Added:
avatar wilsonge
wilsonge - comment - 4 May 2015

Merged - thanks so much!

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment